* [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h
@ 2018-11-08 12:52 Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2018-11-08 12:52 UTC (permalink / raw)
To: qemu-devel; +Cc: patches, Michael Roth
The guest-agent-core.h header was missing the usual guards
against multiple inclusion; add them.
(Spotted by lgtm.com's static analyzer.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
qga/guest-agent-core.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
index 6f4d214cb9f..60eae16f27a 100644
--- a/qga/guest-agent-core.h
+++ b/qga/guest-agent-core.h
@@ -10,6 +10,9 @@
* This work is licensed under the terms of the GNU GPL, version 2 or later.
* See the COPYING file in the top-level directory.
*/
+#ifndef GUEST_AGENT_CORE_H
+#define GUEST_AGENT_CORE_H
+
#include "qapi/qmp/dispatch.h"
#include "qemu-common.h"
#include "qga-qapi-types.h"
@@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
#ifndef _WIN32
void reopen_fd_to_null(int fd);
#endif
+
+#endif /* GUEST_AGENT_CORE_H */
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h
2018-11-08 12:52 [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h Peter Maydell
@ 2018-11-08 12:57 ` Marc-André Lureau
2018-11-08 13:09 ` Philippe Mathieu-Daudé
2018-11-09 14:38 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2018-11-08 12:57 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU, Michael Roth, patches
Hi
On Thu, Nov 8, 2018 at 4:52 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)
neat,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> qga/guest-agent-core.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
> * This work is licensed under the terms of the GNU GPL, version 2 or later.
> * See the COPYING file in the top-level directory.
> */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
> #include "qapi/qmp/dispatch.h"
> #include "qemu-common.h"
> #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
> #ifndef _WIN32
> void reopen_fd_to_null(int fd);
> #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> --
> 2.19.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h
2018-11-08 12:52 [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau
@ 2018-11-08 13:09 ` Philippe Mathieu-Daudé
2018-11-09 14:38 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-08 13:09 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Michael Roth, patches
On 8/11/18 13:52, Peter Maydell wrote:
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> qga/guest-agent-core.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
> * This work is licensed under the terms of the GNU GPL, version 2 or later.
> * See the COPYING file in the top-level directory.
> */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
> #include "qapi/qmp/dispatch.h"
> #include "qemu-common.h"
> #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
> #ifndef _WIN32
> void reopen_fd_to_null(int fd);
> #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h
2018-11-08 12:52 [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau
2018-11-08 13:09 ` Philippe Mathieu-Daudé
@ 2018-11-09 14:38 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Michael Roth @ 2018-11-09 14:38 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: patches
Quoting Peter Maydell (2018-11-08 06:52:23)
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/guest-agent-core.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
> * This work is licensed under the terms of the GNU GPL, version 2 or later.
> * See the COPYING file in the top-level directory.
> */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
> #include "qapi/qmp/dispatch.h"
> #include "qemu-common.h"
> #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
> #ifndef _WIN32
> void reopen_fd_to_null(int fd);
> #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-09 14:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-08 12:52 [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau
2018-11-08 13:09 ` Philippe Mathieu-Daudé
2018-11-09 14:38 ` Michael Roth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).