From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1
Date: Tue, 8 May 2018 22:42:24 +0200 [thread overview]
Message-ID: <e561ca57-1c93-5d9e-94f8-788ee0dce39e@vivier.eu> (raw)
In-Reply-To: <20180508185520.23757-1-richard.henderson@linaro.org>
Le 08/05/2018 à 20:55, Richard Henderson a écrit :
> Fedora 28 ships with the released gcc 8.
>
> The Werror stems from the compiler finding a path through the second
> switch via a missing default case in which src1 is uninitialized, and
> not being able to prove that the missing default case is unreachable
> due to the first switch.
>
> Simplify the second switch to merge default with OS_LONG,
> which returns directly. This removes the unreachable path.
>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/m68k/translate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2018-05-08 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 18:55 [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1 Richard Henderson
2018-05-08 20:42 ` Laurent Vivier [this message]
2018-05-11 11:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e561ca57-1c93-5d9e-94f8-788ee0dce39e@vivier.eu \
--to=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).