From: Hanna Czenczek <hreitz@redhat.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
vsementsov@yandex-team.ru, kwolf@redhat.com
Subject: Re: [PATCH v10 09/12] parallels: Move check of leaks to a separate function
Date: Tue, 7 Mar 2023 13:17:23 +0100 [thread overview]
Message-ID: <e5703b09-2138-3ab7-d750-c1d6d8a940c0@redhat.com> (raw)
In-Reply-To: <20230203091854.2221397-10-alexander.ivanov@virtuozzo.com>
On 03.02.23 10:18, Alexander Ivanov wrote:
> We will add more and more checks so we need a better code structure
> in parallels_co_check. Let each check performs in a separate loop
> in a separate helper.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
> block/parallels.c | 80 ++++++++++++++++++++++++++++-------------------
> 1 file changed, 48 insertions(+), 32 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 994528d93c..c7d37c4580 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -480,21 +480,57 @@ static int parallels_check_outside_image(BlockDriverState *bs,
> return 0;
> }
>
> +static int parallels_check_leak(BlockDriverState *bs,
> + BdrvCheckResult *res,
> + BdrvCheckMode fix)
Like parallels_check_outside_image(), I think ideally this should be
marked as `coroutine_fn GRAPH_RDLOCK` because of the block layer
functions it calls.
Hanna
next prev parent reply other threads:[~2023-03-07 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 9:18 [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 01/12] parallels: Out of image offset in BAT leads to image inflation Alexander Ivanov
2023-02-14 17:44 ` Vladimir Sementsov-Ogievskiy
2023-02-15 11:29 ` Denis V. Lunev
2023-02-15 11:42 ` Vladimir Sementsov-Ogievskiy
2023-02-03 9:18 ` [PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check() Alexander Ivanov
2023-02-14 17:58 ` Vladimir Sementsov-Ogievskiy
2023-02-03 9:18 ` [PATCH v10 03/12] parallels: Fix image_end_offset and data_end after out-of-image check Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 04/12] parallels: create parallels_set_bat_entry_helper() to assign BAT value Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 05/12] parallels: Use generic infrastructure for BAT writing in parallels_co_check() Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 06/12] parallels: Move check of unclean image to a separate function Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 07/12] parallels: Move check of cluster outside " Alexander Ivanov
2023-03-07 12:17 ` Hanna Czenczek
2023-03-10 11:08 ` Alexander Ivanov
2023-03-10 11:11 ` Hanna Czenczek
2023-02-03 9:18 ` [PATCH v10 08/12] parallels: Fix statistics calculation Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 09/12] parallels: Move check of leaks to a separate function Alexander Ivanov
2023-03-07 12:17 ` Hanna Czenczek [this message]
2023-02-03 9:18 ` [PATCH v10 10/12] parallels: Move statistic collection " Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 11/12] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD Alexander Ivanov
2023-02-03 9:18 ` [PATCH v10 12/12] parallels: Incorrect condition in out-of-image check Alexander Ivanov
2023-03-07 12:20 ` [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug Hanna Czenczek
2023-03-13 11:34 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5703b09-2138-3ab7-d750-c1d6d8a940c0@redhat.com \
--to=hreitz@redhat.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).