qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Junkang Fu <fujunkang@gmail.com>, stefanha@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property
Date: Tue, 3 Jan 2017 10:53:06 -0600	[thread overview]
Message-ID: <e57c4b44-ac0c-a937-e088-1f4e086080d8@redhat.com> (raw)
In-Reply-To: <CAP8dc_acqeqpio7fVK4XSAxoH8QaGp9L=S1h2OCCWgrj=Q7VCw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

On 12/29/2016 08:41 PM, Junkang Fu wrote:
>>From 74e913fc41ea98d1dde692175f1e3fb6729342aa Mon Sep 17 00:00:00 2001
> From: "junkang.fjk" <junkang.fjk@alibaba-inc.com>
> Date: Wed, 24 Aug 2016 19:36:53 +0800
> Subject: [PATCH] virtio-blk: add disk-name device property
> 
> Current virtio-blk disk name(ex. /dev/vdb) has nothing to do with the
> target dev
> name specified in libvirt xml file. For example, we may get disk name
> /dev/vdb in
> VM while target dev specified in libvirt xml is vdc.

It's not really libvirt's fault.  The libvirt XML names are for
convenience, but nothing on the host side requires the guest to pick the
same naming scheme as the host.

I guess your proposal is to enhance the virtio spec such that clients
that are new enough to honor the new addition to the virtio spec will
change their name-picking algorithm to use the name provided by the
host, rather than their current approach of picking whatever name they
feel like, and then enhance libvirt to pass the XML name on down to the
guest?  It might work, but as others have pointed out, it will require a
virtio spec change first.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2017-01-03 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  2:41 [Qemu-devel] [RFC]virtio-blk: add disk-name device property Junkang Fu
2016-12-30  7:34 ` Cao jin
2017-01-05  7:36   ` Junkang Fu
2017-01-03 16:29 ` Stefan Hajnoczi
2017-01-05  7:35   ` Junkang Fu
2017-01-03 16:53 ` Eric Blake [this message]
2017-01-04 14:44   ` Stefan Hajnoczi
2017-01-12  1:22     ` Yang Zhang
2017-01-12  2:22       ` Fam Zheng
2017-01-12  7:39         ` Yang Zhang
2017-01-12  8:04           ` Fam Zheng
2017-01-12 14:27         ` Stefan Hajnoczi
2017-01-05  7:34   ` Junkang Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e57c4b44-ac0c-a937-e088-1f4e086080d8@redhat.com \
    --to=eblake@redhat.com \
    --cc=fujunkang@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).