From: Joao Martins <joao.m.martins@oracle.com>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: Yi Liu <yi.l.liu@intel.com>, Eric Auger <eric.auger@redhat.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Avihai Horon <avihaih@nvidia.com>
Subject: Re: [PATCH v3 03/10] vfio/iommufd: Return errno in iommufd_cdev_attach_ioas_hwpt()
Date: Mon, 8 Jul 2024 16:32:29 +0100 [thread overview]
Message-ID: <e57d4d48-0908-46f5-a2de-615c4c1edb5b@oracle.com> (raw)
In-Reply-To: <5420483f-03cf-4383-be73-e3a8ec2a4378@redhat.com>
On 08/07/2024 16:28, Cédric Le Goater wrote:
> Hello Joao,
>
> On 7/8/24 4:34 PM, Joao Martins wrote:
>> In preparation to implement auto domains have the attach function
>> return the errno it got during domain attach instead of a bool.
>>
>> -EINVAL is tracked to track domain incompatibilities, and decide whether
>> to create a new IOMMU domain.
>
> Please leave the return value as a bool unless there is a very
> good reason not to.
>
Error* doesn't store the errno, and thus I can't actually test the number of
errno to know when to bail to the next hwpt. Maybe the commit message wasn't
clear enough there. But not sure if we have an alternative here? Or maybe Error
does store errno, and I totally missed it.
next prev parent reply other threads:[~2024-07-08 15:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 14:34 [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking Joao Martins
2024-07-08 14:34 ` [PATCH v3 01/10] vfio/iommufd: Don't fail to realize on IOMMU_GET_HW_INFO failure Joao Martins
2024-07-09 3:43 ` Duan, Zhenzhong
2024-07-09 8:56 ` Joao Martins
2024-07-09 11:45 ` Joao Martins
2024-07-09 11:50 ` Joao Martins
2024-07-10 2:53 ` Duan, Zhenzhong
2024-07-10 9:29 ` Joao Martins
2024-07-10 9:54 ` Duan, Zhenzhong
2024-07-10 9:56 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 02/10] backends/iommufd: Extend iommufd_backend_get_device_info() to fetch HW capabilities Joao Martins
2024-07-09 6:13 ` Duan, Zhenzhong
2024-07-08 14:34 ` [PATCH v3 03/10] vfio/iommufd: Return errno in iommufd_cdev_attach_ioas_hwpt() Joao Martins
2024-07-08 15:28 ` Cédric Le Goater
2024-07-08 15:32 ` Joao Martins [this message]
2024-07-08 16:28 ` Joao Martins
2024-07-09 6:20 ` Cédric Le Goater
2024-07-09 8:56 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 04/10] vfio/iommufd: Introduce auto domain creation Joao Martins
2024-07-09 6:26 ` Duan, Zhenzhong
2024-07-09 9:00 ` Joao Martins
2024-07-09 6:50 ` Cédric Le Goater
2024-07-09 9:09 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 05/10] vfio/iommufd: Probe and request hwpt dirty tracking capability Joao Martins
2024-07-09 6:28 ` Cédric Le Goater
2024-07-09 9:04 ` Joao Martins
2024-07-09 12:47 ` Joao Martins
2024-07-09 16:53 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 06/10] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support Joao Martins
2024-07-09 7:07 ` Cédric Le Goater
2024-07-09 9:13 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 07/10] vfio/iommufd: Implement VFIOIOMMUClass::query_dirty_bitmap support Joao Martins
2024-07-09 7:05 ` Cédric Le Goater
2024-07-09 9:13 ` Joao Martins
2024-07-09 12:41 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 08/10] vfio/iommufd: Parse hw_caps and store dirty tracking support Joao Martins
2024-07-08 14:34 ` [PATCH v3 09/10] vfio/migration: Don't block migration device dirty tracking is unsupported Joao Martins
2024-07-09 7:02 ` Cédric Le Goater
2024-07-09 9:09 ` Joao Martins
2024-07-10 10:38 ` Duan, Zhenzhong
2024-07-10 10:59 ` Joao Martins
2024-07-08 14:34 ` [PATCH v3 10/10] vfio/common: Allow disabling device dirty page tracking Joao Martins
2024-07-10 10:42 ` Duan, Zhenzhong
2024-07-10 10:51 ` Joao Martins
2024-07-11 7:41 ` [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking Cédric Le Goater
2024-07-11 8:33 ` Joao Martins
2024-07-11 10:22 ` Duan, Zhenzhong
2024-07-11 10:44 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57d4d48-0908-46f5-a2de-615c4c1edb5b@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=avihaih@nvidia.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).