qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mike Frysinger <vapier@gentoo.org>,
	qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user: fix strace build w/out munlockall
Date: Wed, 18 Jan 2023 08:21:33 +0100	[thread overview]
Message-ID: <e57e474b-acbe-07ec-cf6a-84463e5883a7@linaro.org> (raw)
In-Reply-To: <20230117233042.16897-1-vapier@gentoo.org>

On 18/1/23 00:30, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>   linux-user/strace.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 9ae5a812cd71..f7912ad67f2b 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1380,6 +1380,7 @@ UNUSED static struct flags termios_lflags[] = {
>       FLAG_END,
>   };
>   
> +#ifdef TARGET_NR_mlockall
>   UNUSED static struct flags mlockall_flags[] = {

Removing the 'UNUSED' qualifier:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       FLAG_TARGET(MCL_CURRENT),
>       FLAG_TARGET(MCL_FUTURE),
> @@ -1388,6 +1389,7 @@ UNUSED static struct flags mlockall_flags[] = {
>   #endif
>       FLAG_END,
>   };
> +#endif
>   
>   /* IDs of the various system clocks */
>   #define TARGET_CLOCK_REALTIME              0



  reply	other threads:[~2023-01-18  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 23:30 [PATCH] linux-user: fix strace build w/out munlockall Mike Frysinger
2023-01-18  7:21 ` Philippe Mathieu-Daudé [this message]
2023-01-18  9:01 ` [PATCH v2] " Mike Frysinger
2023-01-25 13:25   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e57e474b-acbe-07ec-cf6a-84463e5883a7@linaro.org \
    --to=philmd@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).