From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44C31C433DF for ; Wed, 13 May 2020 21:16:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2113020575 for ; Wed, 13 May 2020 21:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AddcJCiE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2113020575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYyjt-0007La-6J for qemu-devel@archiver.kernel.org; Wed, 13 May 2020 17:16:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYyip-0006jS-6c for qemu-devel@nongnu.org; Wed, 13 May 2020 17:15:23 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:56081 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYyin-0007nj-L1 for qemu-devel@nongnu.org; Wed, 13 May 2020 17:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589404519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/5kxuKk6uoq38M1wBYdVd8MvBOpmqyw3horMBqAkHA=; b=AddcJCiEb+UZVkUZFBnEdLx6oknE2veeKrrtt023gdAS/wud4wEpIDGz+Z4ryRE9zSrAXa KUyI5HCb1rOvBw08cQszxBIaOZvm8aPO4RHbT73dhXyekTPZwyW2Vuc7rfYfUx1mkXS/Vj ybKTOwxJqwiyG5bsV5aLdCl/iJkq+Hc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-mpF9kT5BOv6AgrxXrhUsZg-1; Wed, 13 May 2020 17:15:15 -0400 X-MC-Unique: mpF9kT5BOv6AgrxXrhUsZg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA37018FF660; Wed, 13 May 2020 21:15:14 +0000 (UTC) Received: from [10.3.116.145] (ovpn-116-145.phx2.redhat.com [10.3.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 536765C1D3; Wed, 13 May 2020 21:15:14 +0000 (UTC) Subject: Re: [PATCH v4 34/34] block: Drop @child_class from bdrv_child_perm() To: Max Reitz , qemu-block@nongnu.org References: <20200513110544.176672-1-mreitz@redhat.com> <20200513110544.176672-35-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 13 May 2020 16:15:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200513110544.176672-35-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 01:56:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/13/20 6:05 AM, Max Reitz wrote: > Implementations should decide the necessary permissions based on @role. > > Signed-off-by: Max Reitz > --- > +++ b/block.c > @@ -1947,13 +1947,13 @@ bool bdrv_is_writable(BlockDriverState *bs) > } > > static void bdrv_child_perm(BlockDriverState *bs, BlockDriverState *child_bs, > - BdrvChild *c, const BdrvChildClass *child_class, > - BdrvChildRole role, BlockReopenQueue *reopen_queue, > + BdrvChild *c, BdrvChildRole role, > + BlockReopenQueue *reopen_queue, > uint64_t parent_perm, uint64_t parent_shared, > uint64_t *nperm, uint64_t *nshared) > { > assert(bs->drv && bs->drv->bdrv_child_perm); > - bs->drv->bdrv_child_perm(bs, c, child_class, role, reopen_queue, > + bs->drv->bdrv_child_perm(bs, c, role, reopen_queue, > parent_perm, parent_shared, > nperm, nshared); Is it worth reflowing this call into two lines rather than three? But that's cosmetic. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org