qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kshitij Suri <kshitij.suri@nutanix.com>, qemu-devel@nongnu.org
Cc: soham.ghosh@nutanix.com, berrange@redhat.com,
	prerna.saxena@nutanix.com, armbru@redhat.com,
	dgilbert@redhat.com, philippe.mathieu.daude@gmail.com,
	kraxel@redhat.com, thuth@redhat.com, prachatos.mitra@nutanix.com,
	eblake@redhat.com
Subject: Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG
Date: Tue, 15 Mar 2022 10:17:18 +0100	[thread overview]
Message-ID: <e5a29f66-5d9e-3d4c-be41-aa76ea484cae@redhat.com> (raw)
In-Reply-To: <20220315044740.155268-1-kshitij.suri@nutanix.com>

On 3/15/22 05:47, Kshitij Suri wrote:
> +png = dependency('libpng', required: get_option('png'),
> +                 method: 'pkg-config', kwargs: static_kwargs)

The full way to write it would be:

png = not_found
if get_option('png').allowed() and have_system
   png = dependency('libpng', required: get_option('png'),
                    method: 'pkg-config', kwargs: static_kwargs)
endif

but we can now also use

png = dependency('libpng',
                  required: get_option('png').disable_auto_if(not have_system),
                  method: 'pkg-config', kwargs: static_kwargs)

Use the one that you prefer.

Paolo


  parent reply	other threads:[~2022-03-15  9:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  4:47 [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG Kshitij Suri
2022-03-15  4:47 ` [PATCH v2 2/2] Added parameter to take screenshot with screendump as Kshitij Suri
2022-03-16 13:25   ` Markus Armbruster
2022-03-16 18:15     ` Kshitij Suri
2022-03-17  6:20       ` Markus Armbruster
2022-03-15  9:17 ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-28 16:54 [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG Kshitij Suri
2022-03-22 10:49 Kshitij Suri
2022-03-28  9:49 ` Kshitij Suri
2022-03-22  8:18 Kshitij Suri
2022-03-22  9:42 ` Daniel P. Berrangé
2022-03-22  9:52   ` Kshitij Suri
2022-03-01  6:44 Kshitij Suri
2022-03-07 16:40 ` Kshitij Suri
2022-02-28  5:22 Kshitij Suri
2022-02-28 12:52 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5a29f66-5d9e-3d4c-be41-aa76ea484cae@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kshitij.suri@nutanix.com \
    --cc=philippe.mathieu.daude@gmail.com \
    --cc=prachatos.mitra@nutanix.com \
    --cc=prerna.saxena@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=soham.ghosh@nutanix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).