From: Laurent Vivier <lvivier@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Alberto Garcia" <berto@igalia.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Eric Blake" <eblake@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Fam Zheng" <famz@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-arm@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Max Reitz" <mreitz@redhat.com>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle
Date: Fri, 23 Mar 2018 13:40:07 +0100 [thread overview]
Message-ID: <e5a6598a-6a0f-5dbf-f7ab-6ade2059fcce@redhat.com> (raw)
In-Reply-To: <087177af-cc0b-c8b7-ce50-98f1f9cada68@msgid.tls.msk.ru>
On 23/03/2018 13:37, Michael Tokarev wrote:
> 22.03.2018 19:12, Laurent Vivier wrote:
>> I've re-run some scripts from the coccinelle directory,
>> and they have found some problems.
>>
>> This series fixes them.
>>
>> Laurent Vivier (4):
>> error: Strip trailing '\n' from error string arguments (again again)
>> error: Remove NULL checks on error_propagate() calls
>> qdict: remove useless cast
>> Remove unnecessary variables for function return value
>
> I've applied patches 1-3, but the 4th patch is a bit.. interesting.
> As has already been said, it touches auto-generated files, which is
> sort of fine, but it _also_ removes comments, which - I think - is
> quite a bit wrong.
>
> I can apply just selected hunks, but.. hmm..
Thank you, I'm going to rework this one.
Thanks,
Laurent
next prev parent reply other threads:[~2018-03-23 12:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 16:12 [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again again) Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls Laurent Vivier
2018-03-23 20:50 ` Eric Blake
2018-03-26 8:40 ` Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 3/4] qdict: remove useless cast Laurent Vivier
2018-03-22 16:23 ` Dr. David Alan Gilbert
2018-03-27 3:01 ` Fam Zheng
2018-03-22 16:12 ` [Qemu-devel] [PATCH 4/4] Remove unnecessary variables for function return value Laurent Vivier
2018-03-22 16:45 ` Eric Blake
2018-03-22 16:51 ` Max Filippov
2018-03-22 16:58 ` Laurent Vivier
2018-03-22 17:19 ` Max Filippov
2018-03-22 17:23 ` Peter Maydell
2018-03-22 17:26 ` Max Filippov
2018-03-22 17:30 ` Eric Blake
2018-03-22 17:40 ` Peter Maydell
2018-03-22 16:59 ` Eric Blake
2018-03-22 17:06 ` Max Filippov
2018-03-22 23:06 ` David Gibson
2018-03-23 2:14 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-03-23 10:44 ` [Qemu-devel] " Alberto Garcia
2018-03-22 16:27 ` [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle Eric Blake
2018-03-22 16:45 ` Eric Blake
2018-03-22 17:57 ` no-reply
2018-03-22 18:00 ` Peter Maydell
2018-03-22 19:12 ` Eric Blake
2018-03-22 19:17 ` Peter Maydell
2018-03-23 12:37 ` Michael Tokarev
2018-03-23 12:40 ` Laurent Vivier [this message]
2018-03-23 17:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5a6598a-6a0f-5dbf-f7ab-6ade2059fcce@redhat.com \
--to=lvivier@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=i.mitsyanko@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).