From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org,
mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com,
eduardo@habkost.net, david@redhat.com
Subject: Re: [PATCH 3/4] qtest: Improve error messages when property can not be set right now
Date: Wed, 12 Oct 2022 20:05:32 +0200 [thread overview]
Message-ID: <e5dd172e-1b9f-3817-a87f-3ed52a0ce120@redhat.com> (raw)
In-Reply-To: <20221012153801.2604340-4-armbru@redhat.com>
On 12/10/2022 17.38, Markus Armbruster wrote:
> When you try to set qtest property "log" while the qtest object is
> active, the error message blames "insufficient permission":
>
> $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev socket,id=chrqt0,path=qtest.socket,server=on,wait=off -object qtest,id=qt0,chardev=chrqt0,log=/dev/null
> QEMU 7.1.50 monitor - type 'help' for more information
> (qemu) qom-set /objects/qt0 log qtest.log
> Error: Insufficient permission to perform this operation
>
> This implies it could work with "sufficient permission". It can't.
> Change the error message to:
>
> Error: Property 'log' can not be set now
Can it be set later? ... if not, that error message is almost as confusing
as the original one. Maybe it's better to tell the users *when* they can set
the property?
Thomas
next prev parent reply other threads:[~2022-10-12 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:37 [PATCH 0/4] Replace QERR_PERMISSION_DENIED by better error messages Markus Armbruster
2022-10-12 15:37 ` [PATCH 1/4] qom: Improve error messages when property has no getter or setter Markus Armbruster
2022-10-12 19:24 ` David Hildenbrand
2022-10-12 15:37 ` [PATCH 2/4] backends: Improve error messages when property can no longer be set Markus Armbruster
2022-10-12 15:38 ` [PATCH 3/4] qtest: Improve error messages when property can not be set right now Markus Armbruster
2022-10-12 18:05 ` Thomas Huth [this message]
2022-10-12 19:02 ` David Hildenbrand
2022-10-13 5:02 ` Markus Armbruster
2022-10-27 6:02 ` Markus Armbruster
2022-10-12 15:38 ` [PATCH 4/4] qerror: QERR_PERMISSION_DENIED is no longer used, drop Markus Armbruster
2022-10-26 20:12 ` [PATCH 0/4] Replace QERR_PERMISSION_DENIED by better error messages Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5dd172e-1b9f-3817-a87f-3ed52a0ce120@redhat.com \
--to=thuth@redhat.com \
--cc=amit@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).