* [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test
@ 2023-09-28 3:45 Chris Rauer
2023-09-28 4:44 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Chris Rauer @ 2023-09-28 3:45 UTC (permalink / raw)
To: kfting, wuhaotsh, thuth, lvivier, pbonzini, stefanha
Cc: qemu-arm, qemu-devel, Chris Rauer
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
Signed-off-by: Chris Rauer <crauer@google.com>
---
tests/qtest/npcm7xx_timer-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
index 43711049ca..58f58c2f71 100644
--- a/tests/qtest/npcm7xx_timer-test.c
+++ b/tests/qtest/npcm7xx_timer-test.c
@@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data)
int i;
tim_reset(td);
+ clock_step_next();
tim_write_ticr(td, count);
tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
--
2.42.0.515.g380fc7ccd1-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test
2023-09-28 3:45 [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test Chris Rauer
@ 2023-09-28 4:44 ` Thomas Huth
2023-09-29 0:06 ` Chris Rauer
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2023-09-28 4:44 UTC (permalink / raw)
To: Chris Rauer, kfting, wuhaotsh, lvivier, pbonzini, stefanha
Cc: qemu-arm, qemu-devel
On 28/09/2023 05.45, Chris Rauer wrote:
Could you please add a proper patch description how this is fixing the issue?
Thanks,
Thomas
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
> Signed-off-by: Chris Rauer <crauer@google.com>
> ---
> tests/qtest/npcm7xx_timer-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
> index 43711049ca..58f58c2f71 100644
> --- a/tests/qtest/npcm7xx_timer-test.c
> +++ b/tests/qtest/npcm7xx_timer-test.c
> @@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data)
> int i;
>
> tim_reset(td);
> + clock_step_next();
>
> tim_write_ticr(td, count);
> tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test
2023-09-28 4:44 ` Thomas Huth
@ 2023-09-29 0:06 ` Chris Rauer
0 siblings, 0 replies; 3+ messages in thread
From: Chris Rauer @ 2023-09-29 0:06 UTC (permalink / raw)
To: Thomas Huth
Cc: kfting, wuhaotsh, lvivier, pbonzini, stefanha, qemu-arm,
qemu-devel
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Ack. will send out v2.
On Wed, Sep 27, 2023 at 9:44 PM Thomas Huth <thuth@redhat.com> wrote:
> On 28/09/2023 05.45, Chris Rauer wrote:
>
> Could you please add a proper patch description how this is fixing the
> issue?
>
> Thanks,
> Thomas
>
>
> > Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897
> > Signed-off-by: Chris Rauer <crauer@google.com>
> > ---
> > tests/qtest/npcm7xx_timer-test.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/npcm7xx_timer-test.c
> b/tests/qtest/npcm7xx_timer-test.c
> > index 43711049ca..58f58c2f71 100644
> > --- a/tests/qtest/npcm7xx_timer-test.c
> > +++ b/tests/qtest/npcm7xx_timer-test.c
> > @@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer
> test_data)
> > int i;
> >
> > tim_reset(td);
> > + clock_step_next();
> >
> > tim_write_ticr(td, count);
> > tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
>
>
[-- Attachment #2: Type: text/html, Size: 1555 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-29 0:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 3:45 [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test Chris Rauer
2023-09-28 4:44 ` Thomas Huth
2023-09-29 0:06 ` Chris Rauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).