From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH 6/8] docs/specs/virt-ctlr: Convert to rST
Date: Wed, 8 Nov 2023 11:31:23 +0100 [thread overview]
Message-ID: <e5eae50b-d03c-4524-a540-5581f4796c68@linaro.org> (raw)
In-Reply-To: <CAFEAcA8mQ_r+RJZsDr42Vi88rMT=cRtEVNziKNCkB1AsZXujtg@mail.gmail.com>
On 31/10/23 16:43, Peter Maydell wrote:
> On Tue, 31 Oct 2023 at 15:39, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> On 27/9/23 17:12, Peter Maydell wrote:
>>> Convert docs/specs/virt-ctlr.txt to rST format.
>>>
>>> I added the name of the device to give readers a bit more idea
>>> of which device we're actually documenting here.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> docs/specs/index.rst | 1 +
>>> docs/specs/{virt-ctlr.txt => virt-ctlr.rst} | 12 +++++-------
>>> 2 files changed, 6 insertions(+), 7 deletions(-)
>>> rename docs/specs/{virt-ctlr.txt => virt-ctlr.rst} (70%)
>>
>>
>> $ ./scripts/get_maintainer.pl -f docs/specs/virt-ctlr.txt
>> get_maintainer.pl: No maintainers found, printing recent contributors.
>> get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
>>
>> $ ./scripts/get_maintainer.pl -f hw/misc/virt_ctrl.c
>> Laurent Vivier <laurent@vivier.eu> (maintainer:virt)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>>
>> Cc'ing Laurent.
>
> That raises the question, is it intentional that the doc
> is virt-ctlr but the source file is virt-ctrl ? Should we
> rename one of them (looks like the doc, so easy enough to
> do as part of this patch)?
$ git grep ctlr| wc -l
430
$ git grep ctrl| wc -l
4063
Since you are already renaming the file, correcting the typo
in the same file seems like a good idea.
next prev parent reply other threads:[~2023-11-08 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 15:11 [PATCH 0/8] docs/specs: Convert txt files to rST Peter Maydell
2023-09-27 15:11 ` [PATCH 1/8] docs/specs/vmw_pvscsi-spec: Convert " Peter Maydell
2023-10-19 16:38 ` Thomas Huth
2023-09-27 15:11 ` [PATCH 2/8] docs/specs/edu: " Peter Maydell
2023-10-19 16:48 ` Thomas Huth
2023-09-27 15:12 ` [PATCH 3/8] docs/specs/ivshmem-spec: " Peter Maydell
2023-10-31 15:46 ` Philippe Mathieu-Daudé
2023-09-27 15:12 ` [PATCH 4/8] docs/specs/pvpanic: " Peter Maydell
2023-10-31 15:33 ` Philippe Mathieu-Daudé
2023-09-27 15:12 ` [PATCH 5/8] docs/specs/standard-vga: " Peter Maydell
2023-10-31 15:36 ` Philippe Mathieu-Daudé
2023-09-27 15:12 ` [PATCH 6/8] docs/specs/virt-ctlr: " Peter Maydell
2023-10-31 15:39 ` Philippe Mathieu-Daudé
2023-10-31 15:43 ` Peter Maydell
2023-11-08 10:31 ` Philippe Mathieu-Daudé [this message]
2023-09-27 15:12 ` [PATCH 7/8] docs/specs/vmcoreinfo: " Peter Maydell
2023-10-31 15:42 ` Philippe Mathieu-Daudé
2023-11-02 13:35 ` Marc-André Lureau
2023-09-27 15:12 ` [PATCH 8/8] docs/specs/vmgenid: " Peter Maydell
2023-10-31 15:43 ` Philippe Mathieu-Daudé
2023-11-01 11:48 ` Ani Sinha
2023-10-17 12:46 ` [PATCH 0/8] docs/specs: Convert txt files " Peter Maydell
2023-10-31 14:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5eae50b-d03c-4524-a540-5581f4796c68@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).