From: "Kambalin, Sergey" <sergey.kambalin@auriga.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Sergey Kambalin <serg.oker@gmail.com>
Cc: "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] [rpi4b] Make bootable rpi4b model
Date: Mon, 22 May 2023 10:42:37 +0000 [thread overview]
Message-ID: <e5f053c126a24a62a4e1e8d309d939ce@auriga.com> (raw)
In-Reply-To: <CAFEAcA_aV0DvL3DgqU9SKKRsqCoMrvwbPoomx+NA8fkXKkTytA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]
Hi!
Unfortunately it can't be split without losing a functionality. It is a minimal amount of code to make it able to boot the kernel (and therefore confirm that it works).
________________________________
От: Peter Maydell <peter.maydell@linaro.org>
Отправлено: 22 мая 2023 г. 13:32:52
Кому: Sergey Kambalin
Копия: qemu-arm@nongnu.org; qemu-devel@nongnu.org; Kambalin, Sergey
Тема: Re: [PATCH] [rpi4b] Make bootable rpi4b model
On Mon, 22 May 2023 at 11:29, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
> configs/devices/aarch64-softmmu/default.mak | 2 +
> hw/arm/Kconfig | 7 +
> hw/arm/bcm2835_peripherals.c | 223 ++++++-----
> hw/arm/bcm2836.c | 129 ++++---
> hw/arm/bcm2838.c | 283 ++++++++++++++
> hw/arm/bcm2838_peripherals.c | 213 +++++++++++
> hw/arm/meson.build | 5 +
> hw/arm/raspi.c | 129 ++++---
> hw/arm/raspi4b.c | 243 ++++++++++++
> hw/arm/trace-events | 2 +
> hw/gpio/bcm2838_gpio.c | 395 ++++++++++++++++++++
> hw/gpio/meson.build | 1 +
> hw/misc/bcm2835_powermgt.c | 37 ++
> hw/misc/bcm2835_property.c | 318 +++++++++++++---
> hw/misc/trace-events | 10 +
> include/hw/arm/bcm2835_peripherals.h | 29 +-
> include/hw/arm/bcm2836.h | 30 +-
> include/hw/arm/bcm2838.h | 26 ++
> include/hw/arm/bcm2838_peripherals.h | 50 +++
> include/hw/arm/raspi4b_platform.h | 58 +++
> include/hw/arm/raspi_platform.h | 34 ++
> include/hw/display/bcm2835_fb.h | 2 +
> include/hw/gpio/bcm2838_gpio.h | 45 +++
> include/hw/misc/bcm2835_powermgt.h | 2 +-
> include/hw/misc/raspberrypi-fw-defs.h | 169 +++++++++
> tests/avocado/boot_linux_console.py | 37 ++
> 26 files changed, 2210 insertions(+), 269 deletions(-)
Hi; this is far too large to be reviewable as a single patch.
It must be split into more digestible chunks (each of which
does a single reasonably coherent thing) before we can
do anything with it.
thanks
-- PMM
[-- Attachment #2: Type: text/html, Size: 6599 bytes --]
next prev parent reply other threads:[~2023-05-22 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:29 [PATCH] [rpi4b] Make bootable rpi4b model Sergey Kambalin
2023-05-22 10:32 ` Peter Maydell
2023-05-22 10:42 ` Kambalin, Sergey [this message]
2023-05-22 10:58 ` Peter Maydell
2023-05-22 11:42 ` Kambalin, Sergey
2023-05-22 12:01 ` Peter Maydell
2023-05-22 12:41 ` Kambalin, Sergey
2023-05-22 13:41 ` Philippe Mathieu-Daudé
2023-05-22 15:21 ` Kambalin, Sergey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f053c126a24a62a4e1e8d309d939ce@auriga.com \
--to=sergey.kambalin@auriga.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=serg.oker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).