From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: cfontana@suse.de
Subject: Re: [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed
Date: Sun, 28 Feb 2021 13:39:58 -0800 [thread overview]
Message-ID: <e5f80cc6-7302-93eb-9dc5-d92811b74997@linaro.org> (raw)
In-Reply-To: <8102bde6-d2d3-0058-dddb-db295ce5bfac@amsat.org>
On 2/28/21 8:14 AM, Philippe Mathieu-Daudé wrote:
>> + /* Used for the jazz board to modify mips_cpu_do_transaction_failed. */
>
> Isn't it possible to have other (old) boards doing something similar?
It's possible, but I doubt any need to.
I think the comment in hw/mips/jazz.c is correct, in essence. That we're
simply being bug-compatible with older qemu, and that real jazz hw does not
discriminate between instruction and data loads.
r~
next prev parent reply other threads:[~2021-02-28 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 23:25 [PATCH 0/2] Fix mips jazz vs constant TCGCPUOps Richard Henderson
2021-02-27 23:25 ` [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed Richard Henderson
2021-02-28 16:14 ` Philippe Mathieu-Daudé
2021-02-28 21:39 ` Richard Henderson [this message]
2021-03-01 8:03 ` Philippe Mathieu-Daudé
2021-03-01 8:53 ` Philippe Mathieu-Daudé
2021-02-27 23:25 ` [PATCH 2/2] hw/core: Constify TCGCPUOps Richard Henderson
2021-02-28 16:14 ` Philippe Mathieu-Daudé
2021-02-28 9:59 ` [PATCH 0/2] Fix mips jazz vs constant TCGCPUOps Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f80cc6-7302-93eb-9dc5-d92811b74997@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).