From: Fiona Ebner <f.ebner@proxmox.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Warner Losh <imp@bsdimp.com>,
Richard Henderson <richard.henderson@linaro.org>,
Kyle Evans <kevans@freebsd.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset
Date: Thu, 16 May 2024 13:17:47 +0200 [thread overview]
Message-ID: <e613e65b-fc96-459f-bb5f-c2dcb9518086@proxmox.com> (raw)
In-Reply-To: <20240503123456.28866-6-philmd@linaro.org>
Hi,
Am 03.05.24 um 14:34 schrieb Philippe Mathieu-Daudé:
> In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out")
> we unfortunately restricted the tcg_flush_jmp_cache() to system
> emulation. Move it to the common tcg_exec_cpu_reset_hold() handler
> so user emulation gets the jmp_cache initialized when threads
> are created.
>
> Remove the NULL check in tcg_flush_jmp_cache() from commit 4e4fa6c12d
> ("accel/tcg: Complete cpu initialization before registration") which
> was a band-aid fix for incorrect commit bb6cf6f016.
>
AFAICT, commit 4e4fa6c12d was already present in v7.2.0, while commit
bb6cf6f016 only later in v8.2.0. So is it really fine to remove the NULL
check?
Best Regards,
Fiona
next prev parent reply other threads:[~2024-05-16 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:34 [PATCH v3 0/5] accel/tcg: Call tcg_flush_jmp_cache() again when creating user-mode cpu Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 1/5] accel/tcg: Move SoftMMU specific units to softmmu_specific_ss[] Philippe Mathieu-Daudé
2024-05-06 15:40 ` Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 2/5] accel/tcg: Move system emulation files under sysemu/ subdirectory Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 3/5] accel/tcg: Do not define cpu_exec_reset_hold() as stub Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 4/5] accel/tcg: Introduce common tcg_exec_cpu_reset_hold() method Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset Philippe Mathieu-Daudé
2024-05-16 11:17 ` Fiona Ebner [this message]
2024-08-11 17:43 ` Michael Tokarev
2024-08-13 15:10 ` Philippe Mathieu-Daudé
2024-12-20 21:08 ` Michael Tokarev
2024-12-20 21:33 ` Philippe Mathieu-Daudé
2024-05-03 15:10 ` [PATCH v3 0/5] accel/tcg: Call tcg_flush_jmp_cache() again when creating user-mode cpu Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e613e65b-fc96-459f-bb5f-c2dcb9518086@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=iii@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).