From: Gavin Shan <gshan@redhat.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com, david@redhat.com,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
eric.auger@redhat.com, qemu-arm@nongnu.org, shan.gavin@gmail.com,
imammedo@redhat.com
Subject: Re: [PATCH v2 0/2] hw/arm/virt: Support for virtio-mem-pci
Date: Sat, 4 Dec 2021 10:06:56 +1100 [thread overview]
Message-ID: <e6159135-6bbc-7f2f-2226-e25e29ba3c67@redhat.com> (raw)
In-Reply-To: <20211203141058.00006079@Huawei.com>
Hi Jonathan,
On 12/4/21 1:10 AM, Jonathan Cameron wrote:
> On Fri, 3 Dec 2021 11:35:20 +0800
> Gavin Shan <gshan@redhat.com> wrote:
>
>> This series supports virtio-mem-pci device, by simply following the
>> implementation on x86. The exception is the block size is 512MB on
>> ARM64 instead of 128MB on x86, compatible with the memory section
>> size in linux guest.
>>
>> The work was done by David Hildenbrand and then Jonathan Cameron. I'm
>> taking the patch and putting more efforts, which is all about testing
>> to me at current stage.
>
> Thanks for taking this forwards. What you have here looks good to me, but
> I've not looked at this for a while, so I'll go with whatever David and
> others say :)
>
[...]
I would translate this as your reviewed-by tag, which will be added to v3.
However, it shouldn't stop you from further reviewing :)
Thanks,
Gavin
prev parent reply other threads:[~2021-12-03 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 3:35 [PATCH v2 0/2] hw/arm/virt: Support for virtio-mem-pci Gavin Shan
2021-12-03 3:35 ` [PATCH v2 1/2] " Gavin Shan
2021-12-03 18:18 ` David Hildenbrand
2021-12-03 23:23 ` Gavin Shan
2021-12-03 3:35 ` [PATCH v2 2/2] virtio-mem: Correct default THP size for ARM64 Gavin Shan
2021-12-03 18:16 ` David Hildenbrand
2021-12-03 23:25 ` Gavin Shan
2021-12-03 14:10 ` [PATCH v2 0/2] hw/arm/virt: Support for virtio-mem-pci Jonathan Cameron via
2021-12-03 23:06 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6159135-6bbc-7f2f-2226-e25e29ba3c67@redhat.com \
--to=gshan@redhat.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).