From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D835C636CD for ; Tue, 7 Feb 2023 15:30:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPPu9-00070W-QK; Tue, 07 Feb 2023 10:29:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPPu6-0006yi-FJ for qemu-devel@nongnu.org; Tue, 07 Feb 2023 10:29:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPPu5-00036E-1m for qemu-devel@nongnu.org; Tue, 07 Feb 2023 10:29:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675783744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uKSc/8jFH0gXoMTCJMH5R6e3VIFiikeQr44IgDAeKQw=; b=XPz6XCpM9aXDE0TL/RYC2jE1Zn9gysep6k1S48HRSQlgaQy8sIycpT35vr1CTx6nry3vDi OOGdlbMTwcutfpPzz+IaSHAIDYseQAjrCoY72Qsgje5fDe9hVQEdwCYL+SaJ1YWLzIlnjZ bMrIgIfobz2udAJkl6GR6J4G3i8f6JY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-622-xLCa-K1tOImOvWu0EvkdeQ-1; Tue, 07 Feb 2023 10:28:34 -0500 X-MC-Unique: xLCa-K1tOImOvWu0EvkdeQ-1 Received: by mail-qt1-f199.google.com with SMTP id c16-20020ac85190000000b003b841d1118aso8768271qtn.17 for ; Tue, 07 Feb 2023 07:28:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uKSc/8jFH0gXoMTCJMH5R6e3VIFiikeQr44IgDAeKQw=; b=oAf2vZ9kn2Xfd65MWOP+A08zTXiWqqJTjxitDXcbW0reIGll6bru39Z2m4D6Pfuucm gSXdQDUCRHJUaLdMIIJc23oXL+HcXAWB9y7YHgxf6h56vL4gV8E9m3CRTj6iqoc0s8y+ +M+BadP0hUoyse5TicwK+9tIWwB4ltN90unGWK+5sH2+dnBK0a3bpOibHnFL2VCsTdQt v0KzZv9ZFFpG0Kvo44SYfQxnxRYfQbj6rKOX+H8KI2EjSqKOBo5puZXTWVl5r4ZXradJ 0qkT81YqPp+WV6GcHwjrN/7ce0zKt6xUTaf/VEoYNDqQ7V7sIaUwrrwMzdpgCXMHr+ac mp0A== X-Gm-Message-State: AO0yUKVBZ1+15AqA1WJLr89I3iHqiaKXSgyKCQelfFxvoLJPmI3Pqj5f 5VxpeBOs1WnM3ZieokHRXd/j8PdwQ3un2DWTsUMm/EX/4A2c/7/0JmbuCRjmP+cu4ocTdJobLrz SQPW2khYXpZ0y9Ac= X-Received: by 2002:ac8:5b10:0:b0:3b9:b2c3:9d2e with SMTP id m16-20020ac85b10000000b003b9b2c39d2emr6633106qtw.10.1675783714263; Tue, 07 Feb 2023 07:28:34 -0800 (PST) X-Google-Smtp-Source: AK7set8PrpAbmaD2ax+rBXhyze3NX8v5etDQ6ce64r3iJ6PY/uNRNr9ecnIpZVQNvimtz5FBlxvypw== X-Received: by 2002:ac8:5b10:0:b0:3b9:b2c3:9d2e with SMTP id m16-20020ac85b10000000b003b9b2c39d2emr6633085qtw.10.1675783714053; Tue, 07 Feb 2023 07:28:34 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-176-120.web.vodafone.de. [109.43.176.120]) by smtp.gmail.com with ESMTPSA id q1-20020ac84101000000b003b86d9a3700sm9541856qtl.78.2023.02.07.07.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 07:28:33 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 16:28:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 02/10] hw/i386: Select E1000E for q35 Content-Language: en-US To: Fabiano Rosas , qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , QEMU Trivial References: <20230206140809.26028-1-farosas@suse.de> <20230206140809.26028-3-farosas@suse.de> From: Thomas Huth In-Reply-To: <20230206140809.26028-3-farosas@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 06/02/2023 15.08, Fabiano Rosas wrote: > The e1000e network adapter is the default network card for the q35 > machine. Make sure that CONFIG is always selected for that machine. > > Signed-off-by: Fabiano Rosas > --- > hw/i386/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 1bf47b0b0b..527b95df81 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -93,7 +93,6 @@ config Q35 > bool > imply VTD > imply AMD_IOMMU > - imply E1000E_PCI_EXPRESS > imply VMPORT > imply VMMOUSE > select PC_PCI > @@ -104,6 +103,7 @@ config Q35 > select DIMM > select SMBIOS > select FW_CFG_DMA > + select E1000E_PCI_EXPRESS Reviewed-by: Thomas Huth