From: Paolo Bonzini <pbonzini@redhat.com>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vl, qemu-config: remove -set
Date: Thu, 12 Nov 2020 14:47:17 +0100 [thread overview]
Message-ID: <e6383cfb-de65-654c-25ac-60f43c5d1ddf@redhat.com> (raw)
In-Reply-To: <20201112112656.b2mou3jt74afods3@sirius.home.kraxel.org>
On 12/11/20 12:26, Gerd Hoffmann wrote:
> Yes, that is quite useful for setting device properties which are not
> (yet) supported by libvirt, like this:
>
> <qemu:commandline>
> <qemu:arg value='-set'/>
> <qemu:arg value='device.video0.edid=on'/>
> </qemu:commandline>
>
> Grepping through my libvirt domain config files I see 90% is
> indeed "-set device". But I've also found netdev (set tftp+bootfile
> for "<interface type='user'>").
Hmm... Looks like I will move -set from config-file to vl.c and handle
both QemuOpts and keyval-based options.
Paolo
prev parent reply other threads:[~2020-11-12 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 13:57 [PATCH] vl, qemu-config: remove -set Paolo Bonzini
2020-11-11 15:03 ` Daniel P. Berrangé
2020-11-11 15:48 ` Paolo Bonzini
2020-11-12 6:55 ` Markus Armbruster
2020-11-12 7:08 ` Paolo Bonzini
2020-11-12 11:26 ` Gerd Hoffmann
2020-11-12 13:47 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6383cfb-de65-654c-25ac-60f43c5d1ddf@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).