From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erejy-0004aY-6x for qemu-devel@nongnu.org; Fri, 02 Mar 2018 02:04:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erejv-0001Mt-2m for qemu-devel@nongnu.org; Fri, 02 Mar 2018 02:04:26 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58340 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ereju-0001Mh-Uk for qemu-devel@nongnu.org; Fri, 02 Mar 2018 02:04:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4918407519A for ; Fri, 2 Mar 2018 07:04:11 +0000 (UTC) References: <1519293517-19582-1-git-send-email-thuth@redhat.com> From: Jason Wang Message-ID: Date: Fri, 2 Mar 2018 15:04:03 +0800 MIME-Version: 1.0 In-Reply-To: <1519293517-19582-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/net: Remove unnecessary header includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org On 2018=E5=B9=B402=E6=9C=8822=E6=97=A5 17:58, Thomas Huth wrote: > Headers like "hw/loader.h" and "qemu/sockets.h" are not needed in > the hw/net/*.c files. And Some other headers are included via other > headers already, so we can drop them, too. > > Signed-off-by: Thomas Huth > --- > hw/net/e1000.c | 1 - > hw/net/lance.c | 3 --- > hw/net/ne2000.c | 2 -- > hw/net/pcnet-pci.c | 1 - > hw/net/pcnet.c | 1 - > hw/net/rtl8139.c | 2 -- > hw/net/xgmac.c | 1 - > 7 files changed, 11 deletions(-) > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > index 804ec08..c7f1695 100644 > --- a/hw/net/e1000.c > +++ b/hw/net/e1000.c > @@ -30,7 +30,6 @@ > #include "hw/pci/pci.h" > #include "net/net.h" > #include "net/checksum.h" > -#include "hw/loader.h" > #include "sysemu/sysemu.h" > #include "sysemu/dma.h" > #include "qemu/iov.h" > diff --git a/hw/net/lance.c b/hw/net/lance.c > index 0028bc5..a08d5ac 100644 > --- a/hw/net/lance.c > +++ b/hw/net/lance.c > @@ -36,10 +36,7 @@ > */ > =20 > #include "qemu/osdep.h" > -#include "hw/sysbus.h" > -#include "net/net.h" > #include "qemu/timer.h" > -#include "qemu/sockets.h" > #include "hw/sparc/sparc32_dma.h" > #include "hw/net/lance.h" > #include "trace.h" > diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c > index 687ef84..3a9fc89 100644 > --- a/hw/net/ne2000.c > +++ b/hw/net/ne2000.c > @@ -23,10 +23,8 @@ > */ > #include "qemu/osdep.h" > #include "hw/pci/pci.h" > -#include "net/net.h" > #include "net/eth.h" > #include "ne2000.h" > -#include "hw/loader.h" > #include "sysemu/sysemu.h" > =20 > /* debug NE2000 card */ > diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c > index 0ae5ca4..70dc8b3 100644 > --- a/hw/net/pcnet-pci.c > +++ b/hw/net/pcnet-pci.c > @@ -30,7 +30,6 @@ > #include "qemu/osdep.h" > #include "hw/pci/pci.h" > #include "net/net.h" > -#include "hw/loader.h" > #include "qemu/timer.h" > #include "sysemu/dma.h" > #include "sysemu/sysemu.h" > diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c > index 606b05c..0c44554 100644 > --- a/hw/net/pcnet.c > +++ b/hw/net/pcnet.c > @@ -40,7 +40,6 @@ > #include "net/net.h" > #include "net/eth.h" > #include "qemu/timer.h" > -#include "qemu/sockets.h" > #include "sysemu/sysemu.h" > #include "trace.h" > =20 > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > index 1cc95b8..46daa16 100644 > --- a/hw/net/rtl8139.c > +++ b/hw/net/rtl8139.c > @@ -58,9 +58,7 @@ > #include "qemu/timer.h" > #include "net/net.h" > #include "net/eth.h" > -#include "hw/loader.h" > #include "sysemu/sysemu.h" > -#include "qemu/iov.h" > =20 > /* debug RTL8139 card */ > //#define DEBUG_RTL8139 1 > diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c > index 0843bf1..fa00156 100644 > --- a/hw/net/xgmac.c > +++ b/hw/net/xgmac.c > @@ -28,7 +28,6 @@ > #include "hw/sysbus.h" > #include "qemu/log.h" > #include "net/net.h" > -#include "net/checksum.h" > =20 > #ifdef DEBUG_XGMAC > #define DEBUGF_BRK(message, args...) do { \ Applied. Thanks