From: Hanna Czenczek <hreitz@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, eblake@redhat.com,
den@virtuozzo.com
Subject: Re: [PATCH v2 4/8] qemu-img: add chunk size parameter to compare_buffers()
Date: Tue, 19 Sep 2023 10:32:34 +0200 [thread overview]
Message-ID: <e6492eda-e09d-13ea-93b5-c824b3b3e9cd@redhat.com> (raw)
In-Reply-To: <20230915162016.141771-5-andrey.drobyshev@virtuozzo.com>
On 15.09.23 18:20, Andrey Drobyshev wrote:
> Add @chsize param to the function which, if non-zero, would represent
> the chunk size to be used for comparison. If it's zero, then
> BDRV_SECTOR_SIZE is used as default chunk size, which is the previous
> behaviour.
>
> In particular, we're going to use this param in img_rebase() to make the
> write requests aligned to a predefined alignment value.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
> qemu-img.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
With the comment fix Eric has suggested:
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
next prev parent reply other threads:[~2023-09-19 8:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 16:20 [PATCH v2 0/8] qemu-img: rebase: add compression support Andrey Drobyshev via
2023-09-15 16:20 ` [PATCH v2 1/8] qemu-img: rebase: stop when reaching EOF of old backing file Andrey Drobyshev via
2023-09-15 16:20 ` [PATCH v2 2/8] qemu-iotests: 024: add rebasing test case for overlay_size > backing_size Andrey Drobyshev via
2023-09-15 16:20 ` [PATCH v2 3/8] qemu-img: rebase: use backing files' BlockBackend for buffer alignment Andrey Drobyshev via
2023-09-15 18:39 ` Eric Blake
2023-09-15 19:27 ` Andrey Drobyshev
2023-09-19 8:18 ` Hanna Czenczek
2023-09-19 9:26 ` Andrey Drobyshev
2023-09-15 16:20 ` [PATCH v2 4/8] qemu-img: add chunk size parameter to compare_buffers() Andrey Drobyshev via
2023-09-15 19:28 ` Eric Blake
2023-09-19 8:32 ` Hanna Czenczek [this message]
2023-09-15 16:20 ` [PATCH v2 5/8] qemu-img: rebase: avoid unnecessary COW operations Andrey Drobyshev via
2023-09-15 21:52 ` Eric Blake
2023-09-16 17:45 ` Andrey Drobyshev
2023-09-19 10:46 ` Hanna Czenczek
2023-09-19 16:21 ` Andrey Drobyshev
2023-09-15 16:20 ` [PATCH v2 6/8] iotests/{024, 271}: add testcases for qemu-img rebase Andrey Drobyshev via
2023-09-19 11:08 ` Hanna Czenczek
2023-09-15 16:20 ` [PATCH v2 7/8] qemu-img: add compression option to rebase subcommand Andrey Drobyshev via
2023-09-15 16:20 ` [PATCH v2 8/8] iotests: add tests for "qemu-img rebase" with compression Andrey Drobyshev via
2023-09-19 11:14 ` Hanna Czenczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6492eda-e09d-13ea-93b5-c824b3b3e9cd@redhat.com \
--to=hreitz@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).