From: Stefan Berger <stefanb@linux.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: marcandre.lureau@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/2] tests: Skip over pcrUpdateCounter byte in result comparison
Date: Tue, 7 Jul 2020 13:43:41 -0400 [thread overview]
Message-ID: <e6613b43-2ac8-a503-ad85-bb1dd9e710b2@linux.ibm.com> (raw)
In-Reply-To: <20200707081938.GB18595@umbus.fritz.box>
On 7/7/20 4:19 AM, David Gibson wrote:
> On Tue, Jul 07, 2020 at 12:05:22AM -0400, Stefan Berger wrote:
>> Due to a change in the TPM 2 code the pcrUpdate counter in the
>> PCRRead response is now different, so we skip comparison of the
>> 14th byte.
> Can you elaborate on this a bit, both in the code comment and the
> commit message.
Will do in v3. Basically the TPM 2 code has been 'fixed' to reflect the
pcclient profile more closely and due to the change in PCRs that belong
to the 'TCB group' the response of the TPM2_Pcrread command now returns
a slightly different value for the pcrUpdateCounter value, which
unfortunately breaks the test cases. Leaving the TPM 2 as it was wasn't
a long-term option.
https://github.com/stefanberger/libtpms/commit/0f5d791a7d3431a6831086f5a186cc53149f695f
prev parent reply other threads:[~2020-07-07 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 4:05 [PATCH v2 0/2] tpm: Some fixes Stefan Berger
2020-07-07 4:05 ` [PATCH v2 1/2] tpm: tpm_spapr: Exit on TPM backend failures Stefan Berger
2020-07-07 4:20 ` Philippe Mathieu-Daudé
2020-07-07 8:19 ` David Gibson
2020-07-07 12:52 ` Stefan Berger
2020-07-07 13:24 ` Philippe Mathieu-Daudé
2020-07-07 4:05 ` [PATCH v2 2/2] tests: Skip over pcrUpdateCounter byte in result comparison Stefan Berger
2020-07-07 8:19 ` David Gibson
2020-07-07 17:43 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6613b43-2ac8-a503-ad85-bb1dd9e710b2@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).