From: Richard Henderson <richard.henderson@linaro.org>
To: Nicolin Chen <nicolinc@nvidia.com>,
peter.maydell@linaro.org, mst@redhat.com, imammedo@redhat.com,
anisinha@redhat.com, shannon.zhaosl@gmail.com
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm/virt-acpi-build: Drop local iort_node_offset
Date: Tue, 18 Jun 2024 19:41:15 -0700 [thread overview]
Message-ID: <e66581c8-9216-496a-b7c7-7ad92f90e565@linaro.org> (raw)
In-Reply-To: <20240619001708.926511-1-nicolinc@nvidia.com>
On 6/18/24 17:17, Nicolin Chen wrote:
> Both the other two callers of build_iort_id_mapping() just directly pass
> in the IORT_NODE_OFFSET macro. Keeping a "const uint32_t" local variable
> storing the same value doesn't have any gain.
>
> Simplify this by replacing the only place using this local variable with
> the macro directly.
>
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> hw/arm/virt-acpi-build.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-06-19 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 0:17 [PATCH] hw/arm/virt-acpi-build: Drop local iort_node_offset Nicolin Chen
2024-06-19 2:41 ` Richard Henderson [this message]
2024-06-19 12:59 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66581c8-9216-496a-b7c7-7ad92f90e565@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).