From: WANG Xuerui <i.qemu@xen0n.name>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: git@xen0n.name
Subject: Re: [PATCH v2 09/10] tcg/loongarch64: Use tcg_pcrel_diff in tcg_out_ldst
Date: Sun, 22 Jan 2023 16:22:54 +0800 [thread overview]
Message-ID: <e6663c5d-1888-09d3-3e6b-a9c17ee63101@xen0n.name> (raw)
In-Reply-To: <20230118011123.392823-10-richard.henderson@linaro.org>
On 1/18/23 09:11, Richard Henderson wrote:
> Take the w^x split into account when computing the
> pc-relative distance to an absolute pointer.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/loongarch64/tcg-target.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc
> index 29d75c80eb..d6926bdb83 100644
> --- a/tcg/loongarch64/tcg-target.c.inc
> +++ b/tcg/loongarch64/tcg-target.c.inc
> @@ -702,7 +702,7 @@ static void tcg_out_ldst(TCGContext *s, LoongArchInsn opc, TCGReg data,
> intptr_t imm12 = sextreg(offset, 0, 12);
>
> if (offset != imm12) {
> - intptr_t diff = offset - (uintptr_t)s->code_ptr;
> + intptr_t diff = tcg_pcrel_diff(s, (void *)offset);
>
> if (addr == TCG_REG_ZERO && diff == (int32_t)diff) {
> imm12 = sextreg(diff, 0, 12);
Reviewed-by: WANG Xuerui <git@xen0n.name>
Thanks for the catch!
next prev parent reply other threads:[~2023-01-22 8:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 1:11 [PATCH v2 00/10] tcg/loongarch64: Reorg goto_tb and cleanups Richard Henderson
2023-01-18 1:11 ` [PATCH v2 01/10] target/loongarch: Enable the disassembler for host tcg Richard Henderson
2023-01-22 8:32 ` WANG Xuerui
2023-01-23 8:37 ` Philippe Mathieu-Daudé
2023-01-18 1:11 ` [PATCH v2 02/10] target/loongarch: Disassemble jirl properly Richard Henderson
2023-01-22 8:24 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 03/10] target/loongarch: Disassemble pcadd* addresses Richard Henderson
2023-01-22 8:24 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 04/10] tcg/loongarch64: Optimize immediate loading Richard Henderson
2023-01-22 8:21 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 05/10] tcg/loongarch64: Update tcg-insn-defs.c.inc Richard Henderson
2023-01-22 8:20 ` WANG Xuerui
2023-01-23 8:33 ` Philippe Mathieu-Daudé
2023-01-18 1:11 ` [PATCH v2 06/10] tcg/loongarch64: Introduce tcg_out_addi Richard Henderson
2023-01-23 6:52 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 07/10] tcg/loongarch64: Improve setcond expansion Richard Henderson
2023-01-23 7:10 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 08/10] tcg/loongarch64: Implement movcond Richard Henderson
2023-01-22 8:23 ` WANG Xuerui
2023-01-18 1:11 ` [PATCH v2 09/10] tcg/loongarch64: Use tcg_pcrel_diff in tcg_out_ldst Richard Henderson
2023-01-22 8:22 ` WANG Xuerui [this message]
2023-01-23 8:32 ` Philippe Mathieu-Daudé
2023-01-18 1:11 ` [PATCH v2 10/10] tcg/loongarch64: Reorg goto_tb implementation Richard Henderson
2023-01-23 8:12 ` WANG Xuerui
2023-01-22 8:28 ` [PATCH v2 00/10] tcg/loongarch64: Reorg goto_tb and cleanups WANG Xuerui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6663c5d-1888-09d3-3e6b-a9c17ee63101@xen0n.name \
--to=i.qemu@xen0n.name \
--cc=git@xen0n.name \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).