qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eauger@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Gavin Shan" <gshan@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v5 1/3] arm/virt: don't try to spell out the accelerator
Date: Mon, 6 Feb 2023 13:46:47 +0100	[thread overview]
Message-ID: <e6732349-efa8-afbf-6c69-498643250bfc@redhat.com> (raw)
In-Reply-To: <20230203134433.31513-2-cohuck@redhat.com>

Hi Connie,

On 2/3/23 14:44, Cornelia Huck wrote:
> Just use current_accel_name() directly.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric
> ---
>  hw/arm/virt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index ea2413a0bad7..bdc297a4570c 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -2123,21 +2123,21 @@ static void machvirt_init(MachineState *machine)
>      if (vms->secure && (kvm_enabled() || hvf_enabled())) {
>          error_report("mach-virt: %s does not support providing "
>                       "Security extensions (TrustZone) to the guest CPU",
> -                     kvm_enabled() ? "KVM" : "HVF");
> +                     current_accel_name());
>          exit(1);
>      }
>  
>      if (vms->virt && (kvm_enabled() || hvf_enabled())) {
>          error_report("mach-virt: %s does not support providing "
>                       "Virtualization extensions to the guest CPU",
> -                     kvm_enabled() ? "KVM" : "HVF");
> +                     current_accel_name());
>          exit(1);
>      }
>  
>      if (vms->mte && (kvm_enabled() || hvf_enabled())) {
>          error_report("mach-virt: %s does not support providing "
>                       "MTE to the guest CPU",
> -                     kvm_enabled() ? "KVM" : "HVF");
> +                     current_accel_name());
>          exit(1);
>      }
>  



  parent reply	other threads:[~2023-02-06 12:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 13:44 [PATCH v5 0/3] arm: enable MTE for QEMU + kvm Cornelia Huck
2023-02-03 13:44 ` [PATCH v5 1/3] arm/virt: don't try to spell out the accelerator Cornelia Huck
2023-02-03 19:32   ` Richard Henderson
2023-02-06 12:46   ` Eric Auger [this message]
2023-02-03 13:44 ` [PATCH v5 2/3] arm/kvm: add support for MTE Cornelia Huck
2023-02-03 20:40   ` Richard Henderson
2023-02-06 13:10     ` Eric Auger
2023-02-06 16:15       ` Cornelia Huck
2023-02-27 15:12         ` Cornelia Huck
2023-02-06 16:41     ` Cornelia Huck
2023-02-06 13:32   ` Eric Auger
2023-02-06 18:27     ` Richard Henderson
2023-02-15 10:36       ` Eric Auger
2023-02-27 15:11         ` Cornelia Huck
2023-02-03 13:44 ` [PATCH v5 3/3] qtests/arm: add some mte tests Cornelia Huck
2023-02-06 18:23   ` Eric Auger
2023-02-10 15:35     ` Cornelia Huck
2023-02-27 15:16       ` Cornelia Huck
2023-02-15 10:59     ` Cornelia Huck
2023-02-16 17:30       ` Eric Auger
2023-02-16 11:40 ` [PATCH v5 0/3] arm: enable MTE for QEMU + kvm Peter Maydell
2023-02-16 11:46   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6732349-efa8-afbf-6c69-498643250bfc@redhat.com \
    --to=eauger@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=gshan@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).