From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Libvirt <libvir-list@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] ui: Mark the '-no-quit' option as deprecated
Date: Wed, 30 Jun 2021 12:16:18 +0200 [thread overview]
Message-ID: <e67d70cd-1e0c-5618-2572-3e0aa95049ff@redhat.com> (raw)
In-Reply-To: <CAFEAcA_XDvTxRHWE3TwP-hZk_DeS-AUCyv9-WZCYKE3zQtSU6Q@mail.gmail.com>
On 30/06/2021 12.01, Peter Maydell wrote:
> On Wed, 30 Jun 2021 at 10:22, Thomas Huth <thuth@redhat.com> wrote:
>>
>> It's just a cumbersome wrapper around the -display ...,window_close=off
>> parameter, so we should rather tell our users to use that instead.
>
> This is an interesting definition of "cumbersome" -- personally
> I would say the long -display option is the cumbersome one :-)
The cumbersome was rather meant from a code / maintenance side of view. But
I think the naming of this parameter is also quite misleading. It really
just blocks the closing button of the window, you can still quit QEMU by
other means (e.g. with the "Quit" menu item in the GTK menu or by shutting
down the guest), so the "window_close=off" wording is certainly more
understandable.
... and by the way, I think the documentation in qemu-options.hx is
inaccurate, too, it only talks about SDL, but it seems like this option is
also available with GTK. So this -no-quit option really seems like old cruft
to me which we should try to get rid of...
Thomas
next prev parent reply other threads:[~2021-06-30 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 9:21 [PATCH] ui: Mark the '-no-quit' option as deprecated Thomas Huth
2021-06-30 9:24 ` Daniel P. Berrangé
2021-06-30 10:01 ` Peter Maydell
2021-06-30 10:07 ` Daniel P. Berrangé
2021-06-30 10:16 ` Thomas Huth [this message]
2021-06-30 10:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67d70cd-1e0c-5618-2572-3e0aa95049ff@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).