From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D955C433E0 for ; Wed, 13 Jan 2021 22:39:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4D5D23370 for ; Wed, 13 Jan 2021 22:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4D5D23370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzon5-0006B0-AG for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 17:38:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzoly-0005Jq-Bb for qemu-devel@nongnu.org; Wed, 13 Jan 2021 17:37:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzolt-0002x4-ME for qemu-devel@nongnu.org; Wed, 13 Jan 2021 17:37:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610577464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NsVhQTPK/jR6cdBubVrQII6gt4Zudg7Qf4p3dS8MBII=; b=IveeRt2HSaSs/dEqlYazheQk9DcVi7G147w5EXLVCroUsDOmTschwixir8Jyb/nRDdH+IR CXFZKn7r7JD3y/hAIqCFmii4P3Zl7CPZsTwP5jwyBuWvK2Dysk3wcKUiV8sEIEEF4RWoWz VM4J+5vRreMkps4FFPaHAUfP2fHjnUE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-JskM-g_RPnCHgYdJ6FWY_w-1; Wed, 13 Jan 2021 17:37:40 -0500 X-MC-Unique: JskM-g_RPnCHgYdJ6FWY_w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4242380DDE0; Wed, 13 Jan 2021 22:37:39 +0000 (UTC) Received: from [10.3.113.36] (ovpn-113-36.phx2.redhat.com [10.3.113.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 858721F0; Wed, 13 Jan 2021 22:37:38 +0000 (UTC) Subject: Re: [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210109122631.167314-1-vsementsov@virtuozzo.com> <20210109122631.167314-2-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 13 Jan 2021 16:37:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210109122631.167314-2-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote: > If you run './check 277', check includes common.config which adjusts > $PATH to include '.' first, and therefore finds nbd-fault-injector.py > on PATH. But if you run './277' directly, there is nothing to adjust > PATH, and if '.' is not already on your PATH by other means, the test > fails because the executable is not found. Adjust how we invoke the > helper executable to avoid needing a PATH search in the first place. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/277 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) As this one touches NBD, I'm happy to queue it in my next NBD pull request if the entire series takes longer to collect enough reviews. > > diff --git a/tests/qemu-iotests/277 b/tests/qemu-iotests/277 > index d34f87021f..a39ce2d873 100755 > --- a/tests/qemu-iotests/277 > +++ b/tests/qemu-iotests/277 > @@ -42,7 +42,7 @@ def make_conf_file(event): > def start_server_NBD(event): > make_conf_file(event) > > - srv = subprocess.Popen(['nbd-fault-injector.py', '--classic-negotiation', > + srv = subprocess.Popen(['./nbd-fault-injector.py', '--classic-negotiation', > nbd_sock, conf_file], stdout=subprocess.PIPE, > stderr=subprocess.STDOUT, universal_newlines=True) > line = srv.stdout.readline() > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org