From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dahq2-00070f-Kt for qemu-devel@nongnu.org; Thu, 27 Jul 2017 08:24:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dahpz-000063-I7 for qemu-devel@nongnu.org; Thu, 27 Jul 2017 08:24:22 -0400 References: <20170727120210.6943-1-crosa@redhat.com> <20170727120210.6943-2-crosa@redhat.com> From: Eric Blake Message-ID: Date: Thu, 27 Jul 2017 07:24:16 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W8TFJp0V4wfWb40vtj4a1n2MMMKuMDquC" Subject: Re: [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Cleber Rosa Cc: QEMU Trivial , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W8TFJp0V4wfWb40vtj4a1n2MMMKuMDquC From: Eric Blake To: Peter Maydell , Cleber Rosa Cc: QEMU Trivial , QEMU Developers Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header References: <20170727120210.6943-1-crosa@redhat.com> <20170727120210.6943-2-crosa@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/27/2017 07:15 AM, Peter Maydell wrote: > On 27 July 2017 at 13:02, Cleber Rosa wrote: >> The generation of the informational header on config.log contains two >> pairs of single quotes, which seems unintentional, and looks like >> this: >> >> # QEMU configure log Thu Jul 26 08:17:15 EDT 2017 >> # Configured with: './configure' '--target-list=3Dx86_64-softmmu' >=20 > I think this is deliberate. The idea is that the string is a > validly shell-quoted string that you can cut and paste > into a shell prompt if you want to. It IS deliberate. If you want, you could improve the code to only emit '' around arguments that require it rather than all arguments, but that requires more shell code (it's easier to quote everywhere, even when it looks strange because the quotes weren't necessary). > ...and note in particular how the '--cc=3Dccache gcc' argument > is printed. Yes, that's a case where the quotes are necessary. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --W8TFJp0V4wfWb40vtj4a1n2MMMKuMDquC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAll523AACgkQp6FrSiUn Q2qYSAf/ZGJilzw3J3/3i5vjW/tyY0vUqFAg8VrkWk+Du+nn3nq17tm0dskDmzci oh9rhWa+v9Kpzcv5nL+26Rw81HPCEK6OH76SLJSPWT7e4Zn85lHuaMTbP/DTRRyP sJAXBkPkx+3X0USB2axi9wIqGIYCN88L/p4pHM0EAnfyDElf24LoYKx1MhRZPg35 gTVSNy4cx8zL4dFiPLrLpjOCFvQGLhF2d+eWm6OQ2q9lXpGG/TQPfBE68eEGU58m /GXRdqQ6ICvElxOz3WBj39op/2lO3ofX+66FFu9FjkJrYZAbe51cUCynMTr+pSlW jT3SXa1vHbVkrhXoAwMbpcC6+J7PWw== =RJRX -----END PGP SIGNATURE----- --W8TFJp0V4wfWb40vtj4a1n2MMMKuMDquC--