From: Thomas Huth <thuth@redhat.com>
To: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, qemu-devel@nongnu.org
Cc: yuval.shaia@oracle.com, rebecca@bluestop.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH V2] config: split PVRDMA from RDMA
Date: Thu, 16 Aug 2018 17:48:28 +0200 [thread overview]
Message-ID: <e69c3f04-acce-b6e8-7254-22edd5d04e4e@redhat.com> (raw)
In-Reply-To: <20180816151637.24553-1-marcel.apfelbaum@gmail.com>
On 08/16/2018 05:16 PM, Marcel Apfelbaum wrote:
> In some BSD systems RDMA migration is possible while
> the pvrdma device can't be used because the mremap system call
> is missing.
>
> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
> configure | 55 ++++++++++++++++++++++++++++++++++++++++++-
> hw/rdma/Makefile.objs | 2 +-
> 2 files changed, 55 insertions(+), 2 deletions(-)
[...]
> diff --git a/hw/rdma/Makefile.objs b/hw/rdma/Makefile.objs
> index 3504c39d21..bd36cbf51c 100644
> --- a/hw/rdma/Makefile.objs
> +++ b/hw/rdma/Makefile.objs
> @@ -1,4 +1,4 @@
> -ifeq ($(CONFIG_RDMA),y)
> +ifeq ($(CONFIG_PVRDMA),y)
> obj-$(CONFIG_PCI) += rdma_utils.o rdma_backend.o rdma_rm.o
> obj-$(CONFIG_PCI) += vmw/pvrdma_dev_ring.o vmw/pvrdma_cmd.o \
> vmw/pvrdma_qp_ops.o vmw/pvrdma_main.o
>
Again: Shouldn't the CONFIG_PVRDMA only guard the second line? I thought
the first list should be fine with CONFIG_RDMA?
Thomas
next prev parent reply other threads:[~2018-08-16 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 15:16 [Qemu-devel] [PATCH V2] config: split PVRDMA from RDMA Marcel Apfelbaum
2018-08-16 15:43 ` Marcel Apfelbaum
2018-08-16 15:48 ` Thomas Huth [this message]
2018-08-16 15:58 ` Marcel Apfelbaum
2018-08-16 16:00 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69c3f04-acce-b6e8-7254-22edd5d04e4e@redhat.com \
--to=thuth@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rebecca@bluestop.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).