From: Thomas Huth <thuth@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>, mst@redhat.com
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases
Date: Fri, 15 Dec 2017 12:10:56 +0100 [thread overview]
Message-ID: <e69f5264-9da3-2bbf-e0f9-3c1e989d7260@redhat.com> (raw)
In-Reply-To: <20171215101651.13911-4-david@gibson.dropbear.id.au>
On 15.12.2017 11:16, David Gibson wrote:
> This adds IPv6 net boot testing (in addition to IPv4) when in slow test
> mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing
> out BIOS image doesn't support it.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tests/pxe-test.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
[...]
> } else if (strcmp(arch, "ppc64") == 0) {
> - test_batch(ppc64_tests);
> + test_batch(ppc64_tests, g_test_slow());
> if (g_test_slow()) {
> - test_batch(ppc64_tests_slow);
> + test_batch(ppc64_tests_slow, true);
> }
The NICs from ppc64_tests_slow are now never exercised with IPv4 ...
maybe it would be better to do both:
test_batch(ppc64_tests_slow, false);
test_batch(ppc64_tests_slow, true);
?
Thomas
next prev parent reply other threads:[~2017-12-15 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 10:16 [Qemu-devel] [PATCH 0/4] Improvements to pxe-test David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions David Gibson
2017-12-15 10:54 ` Thomas Huth
2017-12-15 10:16 ` [Qemu-devel] [PATCH 2/4] tests/pxe-test: Use table of testcases rather than open-coding David Gibson
2017-12-15 11:08 ` Thomas Huth
2017-12-15 12:54 ` David Gibson
2017-12-15 10:16 ` [Qemu-devel] [PATCH 3/4] tests/pxe-test: Test net booting over IPv6 in some cases David Gibson
2017-12-15 11:10 ` Thomas Huth [this message]
2017-12-15 12:56 ` David Gibson
2017-12-15 14:15 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-12-15 10:16 ` [Qemu-devel] [PATCH 4/4] tests/pxe-test: Add some extra tests David Gibson
2017-12-15 10:51 ` Thomas Huth
2017-12-15 12:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69f5264-9da3-2bbf-e0f9-3c1e989d7260@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).