From: Julia Suvorova <jusual@mail.ru>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
Jim Mussared <jim@groklearning.com>,
Joel Stanley <joel@jms.id.au>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename
Date: Thu, 1 Mar 2018 15:02:24 +0300 [thread overview]
Message-ID: <e6d8caaa-8fa5-ffa9-c447-f74be604539b@mail.ru> (raw)
In-Reply-To: <f24ccad5-af69-9c3d-fd9f-b1c1ea6a70c6@redhat.com>
On 01.03.2018 14:21, Paolo Bonzini wrote:
> On 01/03/2018 11:59, Cornelia Huck wrote:
>>>>
>>>> Signed-off-by: Julia Suvorova <jusual@mail.ru>
>>> What about adding a warning for basename()/dirname() usage in
>>> scripts/checkpatch.pl ?
>> +1 to that.
>>
>
> Good idea indeed. Julia, would you like to send a second patch that
> adds the warning?
>
Ok, sure.
> There are already some examples (__FUNCTION__, strto*, signal, etc.)
> that you can take inspiration from.
>
Thanks for the tips.
next prev parent reply other threads:[~2018-03-01 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 7:08 [Qemu-devel] [PATCH] use g_path_get_basename instead of basename Julia Suvorova
2018-03-01 9:47 ` Marc-André Lureau
2018-03-01 10:59 ` Cornelia Huck
2018-03-01 11:21 ` Paolo Bonzini
2018-03-01 12:02 ` Julia Suvorova [this message]
2018-03-01 11:25 ` Julia Suvorova
2018-03-01 11:19 ` Paolo Bonzini
2018-03-01 16:20 ` Alex Williamson
2018-03-02 10:50 ` Paolo Bonzini
2018-03-02 15:20 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6d8caaa-8fa5-ffa9-c447-f74be604539b@mail.ru \
--to=jusual@mail.ru \
--cc=cohuck@redhat.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).