From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2F3R-0001Dg-MU for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:15:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2F3M-0001Jz-5u for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:15:29 -0400 Received: from mga04.intel.com ([192.55.52.120]:18091) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2F3L-0001JW-TD for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:15:24 -0400 References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com> <20161103095353.GA5154@stefanha-x1.localdomain> From: Xiao Guangrong Message-ID: Date: Thu, 3 Nov 2016 18:08:04 +0800 MIME-Version: 1.0 In-Reply-To: <20161103095353.GA5154@stefanha-x1.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: > On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: >> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr) >> cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out)); >> } >> >> +#define NVDIMM_DSM_RET_STATUS_SUCCESS 0 /* Success */ >> +#define NVDIMM_DSM_RET_STATUS_UNSUPPORT 1 /* Not Supported */ >> +#define NVDIMM_DSM_RET_STATUS_INVALID 3 /* Invalid Input Parameters */ > > Not worth changing but please make each logical change a separate patch > in the future. This patch is cluttered with NVDIMM_DSM_RET_STATUS_ > constant renaming. It's easier to review, bisect, and backport when > structured as separate patches. > Yes, indeed. Thanks for your suggestion, will pay more attention. :P