From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 4/6] tcg/tci: Disable -Wundef FFI_GO_CLOSURES warning
Date: Wed, 3 Dec 2025 18:21:18 +0100 [thread overview]
Message-ID: <e6e3c7fb-0d3b-44b4-8a34-e07359de82af@linaro.org> (raw)
In-Reply-To: <20251203161500.501084-5-richard.henderson@linaro.org>
On 3/12/25 17:14, Richard Henderson wrote:
> Since we build TCI with FFI (commit 22f15579fa1 "tcg: Build ffi data
> structures for helpers") we get on Darwin:
>
> In file included from ../../tcg/tci.c:22:
> In file included from include/tcg/helper-info.h:13:
> /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/ffi/ffi.h:483:5: warning: 'FFI_GO_CLOSURES' is not defined, evaluates to 0 [-Wundef]
> 483 | #if FFI_GO_CLOSURES
> | ^
> 1 warning generated.
>
> This was fixed in upstream libffi in 2023, but not backported to MacOSX.
> Simply disable the warning locally.
>
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/tcg/helper-info.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-12-03 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 16:14 [PATCH v3 0/6] tci and macosx fixes Richard Henderson
2025-12-03 16:14 ` [PATCH v3 1/6] tcg: Zero extend 32-bit addresses for TCI Richard Henderson
2025-12-03 16:14 ` [PATCH v3 2/6] tcg/tci: Introduce INDEX_op_tci_qemu_{ld,st}_rrr Richard Henderson
2025-12-03 17:22 ` Philippe Mathieu-Daudé
2025-12-03 16:14 ` [PATCH v3 3/6] tcg: Remove duplicate test from plugin_gen_mem_callbacks Richard Henderson
2025-12-03 17:25 ` Philippe Mathieu-Daudé
2025-12-03 16:14 ` [PATCH v3 4/6] tcg/tci: Disable -Wundef FFI_GO_CLOSURES warning Richard Henderson
2025-12-03 17:21 ` Philippe Mathieu-Daudé [this message]
2025-12-03 16:14 ` [PATCH v3 5/6] include/generic/host: Fix atomic128-cas.h.inc for Int128 structure Richard Henderson
2025-12-03 17:28 ` Philippe Mathieu-Daudé
2025-12-03 16:14 ` [PATCH v3 6/6] include/aarch64/host: Fix atomic16_fetch_{and,or} Richard Henderson
2025-12-03 17:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6e3c7fb-0d3b-44b4-8a34-e07359de82af@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).