* Re: [PATCH] s390/sclp: fix SCLP facility map
[not found] <20231024100703.929679-1-hca@linux.ibm.com>
@ 2023-11-02 18:50 ` Eric Farman
2023-11-07 9:45 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Eric Farman @ 2023-11-02 18:50 UTC (permalink / raw)
To: Heiko Carstens, Thomas Huth, Halil Pasic, Christian Borntraeger
Cc: qemu-s390x, qemu-devel
(+cc qemu-devel)
On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote:
> Qemu's SCLP implementation incorrectly reports that it supports CPU
> reconfiguration. If a guest issues a CPU reconfiguration request it
> is rejected as invalid command.
>
> Fix the SCLP_HAS_CPU_INFO mask, and remove the unused
> SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines.
>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> include/hw/s390x/sclp.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thomas, any concerns? Could this get picked up for 8.2, please?
>
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index 9aef6d937012..b4ecd04e2341 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -38,10 +38,8 @@
> #define MAX_STORAGE_INCREMENTS 1020
>
> /* CPU hotplug SCLP codes */
> -#define SCLP_HAS_CPU_INFO
> 0x0C00000000000000ULL
> +#define SCLP_HAS_CPU_INFO
> 0x0800000000000000ULL
> #define SCLP_CMDW_READ_CPU_INFO 0x00010001
> -#define SCLP_CMDW_CONFIGURE_CPU 0x00110001
> -#define SCLP_CMDW_DECONFIGURE_CPU 0x00100001
>
> /* SCLP PCI codes */
> #define SCLP_HAS_IOA_RECONFIG
> 0x0000000040000000ULL
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/sclp: fix SCLP facility map
2023-11-02 18:50 ` [PATCH] s390/sclp: fix SCLP facility map Eric Farman
@ 2023-11-07 9:45 ` Thomas Huth
2023-11-07 13:57 ` Eric Farman
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2023-11-07 9:45 UTC (permalink / raw)
To: Eric Farman, Heiko Carstens, Halil Pasic, Christian Borntraeger
Cc: qemu-s390x, qemu-devel
On 02/11/2023 19.50, Eric Farman wrote:
> (+cc qemu-devel)
>
> On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote:
>> Qemu's SCLP implementation incorrectly reports that it supports CPU
>> reconfiguration. If a guest issues a CPU reconfiguration request it
>> is rejected as invalid command.
>>
>> Fix the SCLP_HAS_CPU_INFO mask, and remove the unused
>> SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines.
>>
>> Reviewed-by: Eric Farman <farman@linux.ibm.com>
>> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
>> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
>> ---
>> include/hw/s390x/sclp.h | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Thomas, any concerns? Could this get picked up for 8.2, please?
Sorry, been away from keyboard for the last 10 days... queued it now!
Thomas
>>
>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
>> index 9aef6d937012..b4ecd04e2341 100644
>> --- a/include/hw/s390x/sclp.h
>> +++ b/include/hw/s390x/sclp.h
>> @@ -38,10 +38,8 @@
>> #define MAX_STORAGE_INCREMENTS 1020
>>
>> /* CPU hotplug SCLP codes */
>> -#define SCLP_HAS_CPU_INFO
>> 0x0C00000000000000ULL
>> +#define SCLP_HAS_CPU_INFO
>> 0x0800000000000000ULL
>> #define SCLP_CMDW_READ_CPU_INFO 0x00010001
>> -#define SCLP_CMDW_CONFIGURE_CPU 0x00110001
>> -#define SCLP_CMDW_DECONFIGURE_CPU 0x00100001
>>
>> /* SCLP PCI codes */
>> #define SCLP_HAS_IOA_RECONFIG
>> 0x0000000040000000ULL
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/sclp: fix SCLP facility map
2023-11-07 9:45 ` Thomas Huth
@ 2023-11-07 13:57 ` Eric Farman
0 siblings, 0 replies; 3+ messages in thread
From: Eric Farman @ 2023-11-07 13:57 UTC (permalink / raw)
To: Thomas Huth, Heiko Carstens, Halil Pasic, Christian Borntraeger
Cc: qemu-s390x, qemu-devel
On Tue, 2023-11-07 at 10:45 +0100, Thomas Huth wrote:
> On 02/11/2023 19.50, Eric Farman wrote:
> > (+cc qemu-devel)
> >
> > On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote:
> > > Qemu's SCLP implementation incorrectly reports that it supports
> > > CPU
> > > reconfiguration. If a guest issues a CPU reconfiguration request
> > > it
> > > is rejected as invalid command.
> > >
> > > Fix the SCLP_HAS_CPU_INFO mask, and remove the unused
> > > SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines.
> > >
> > > Reviewed-by: Eric Farman <farman@linux.ibm.com>
> > > Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> > > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> > > ---
> > > include/hw/s390x/sclp.h | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Thomas, any concerns? Could this get picked up for 8.2, please?
>
> Sorry, been away from keyboard for the last 10 days... queued it now!
Ah, nice, hope it was refreshing. Thank you!
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-07 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231024100703.929679-1-hca@linux.ibm.com>
2023-11-02 18:50 ` [PATCH] s390/sclp: fix SCLP facility map Eric Farman
2023-11-07 9:45 ` Thomas Huth
2023-11-07 13:57 ` Eric Farman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).