From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"open list:Overall KVM CPUs" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Eric Farman" <farman@linux.ibm.com>,
"Peter Xu" <peterx@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Vikram Garhwal" <fnu.vikram@xilinx.com>,
"open list:virtio-blk" <qemu-block@nongnu.org>,
"David Hildenbrand" <david@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Pavel Pisa" <pisa@cmp.felk.cvut.cz>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"open list:S390 SCLP-backed..." <qemu-s390x@nongnu.org>,
"open list:ARM PrimeCell and..." <qemu-arm@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"open list:PowerPC TCG CPUs" <qemu-ppc@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Eduardo Habkost" <eduardo@habkost.net>,
"open list:RISC-V TCG CPUs" <qemu-riscv@nongnu.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Coiby Xu" <Coiby.Xu@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN
Date: Wed, 16 Mar 2022 14:04:36 +0100 [thread overview]
Message-ID: <e709547a-a0c2-d1bd-7145-d03e9fd1776a@gmail.com> (raw)
In-Reply-To: <20220316095308.2613651-1-marcandre.lureau@redhat.com>
On 16/3/22 10:53, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Replace a config-time define with a compile time condition
> define (compatible with clang and gcc) that must be declared prior to
> its usage. This avoids having a global configure time define, but also
> prevents from bad usage, if the config header wasn't included before.
>
> This can help to make some code independent from qemu too.
>
> gcc supports __BYTE_ORDER__ from about 4.6 and clang from 3.2.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 1 -
> accel/tcg/atomic_template.h | 4 +-
> audio/audio.h | 2 +-
> hw/display/pl110_template.h | 6 +--
> hw/net/can/ctucan_core.h | 2 +-
> hw/net/vmxnet3.h | 4 +-
> include/exec/cpu-all.h | 4 +-
> include/exec/cpu-common.h | 2 +-
> include/exec/memop.h | 2 +-
> include/exec/memory.h | 2 +-
> include/fpu/softfloat-types.h | 2 +-
> include/hw/core/cpu.h | 2 +-
> include/hw/i386/intel_iommu.h | 6 +--
> include/hw/i386/x86-iommu.h | 4 +-
> include/hw/virtio/virtio-access.h | 6 +--
> include/hw/virtio/virtio-gpu-bswap.h | 2 +-
> include/libdecnumber/dconfig.h | 2 +-
> include/net/eth.h | 2 +-
> include/qemu/bswap.h | 8 ++--
> include/qemu/compiler.h | 2 +
> include/qemu/host-utils.h | 2 +-
> include/qemu/int128.h | 2 +-
> include/ui/qemu-pixman.h | 2 +-
> net/util.h | 2 +-
> target/arm/cpu.h | 8 ++--
> target/arm/translate-a64.h | 2 +-
> target/arm/vec_internal.h | 2 +-
> target/i386/cpu.h | 2 +-
> target/mips/cpu.h | 2 +-
> target/ppc/cpu.h | 2 +-
> target/s390x/tcg/vec.h | 2 +-
> target/xtensa/cpu.h | 2 +-
> tests/fp/platform.h | 4 +-
> accel/kvm/kvm-all.c | 4 +-
> audio/dbusaudio.c | 2 +-
> disas.c | 2 +-
> hw/core/loader.c | 4 +-
> hw/display/artist.c | 6 +--
> hw/display/pxa2xx_lcd.c | 2 +-
> hw/display/vga.c | 12 +++---
> hw/display/virtio-gpu-gl.c | 2 +-
> hw/s390x/event-facility.c | 2 +-
> hw/virtio/vhost.c | 2 +-
> linux-user/arm/nwfpe/double_cpdo.c | 4 +-
> linux-user/arm/nwfpe/fpa11_cpdt.c | 4 +-
> linux-user/ppc/signal.c | 3 +-
> linux-user/syscall.c | 6 +--
> net/net.c | 4 +-
> target/alpha/translate.c | 2 +-
> target/arm/crypto_helper.c | 2 +-
> target/arm/helper.c | 2 +-
> target/arm/kvm64.c | 4 +-
> target/arm/neon_helper.c | 2 +-
> target/arm/sve_helper.c | 4 +-
> target/arm/translate-sve.c | 6 +--
> target/arm/translate-vfp.c | 2 +-
> target/arm/translate.c | 2 +-
> target/hppa/translate.c | 2 +-
> target/i386/tcg/translate.c | 2 +-
> target/mips/tcg/lmmi_helper.c | 2 +-
> target/mips/tcg/msa_helper.c | 54 ++++++++++++-------------
> target/ppc/arch_dump.c | 2 +-
> target/ppc/int_helper.c | 22 +++++-----
> target/ppc/kvm.c | 4 +-
> target/ppc/mem_helper.c | 2 +-
> target/riscv/vector_helper.c | 2 +-
> target/s390x/tcg/translate.c | 2 +-
> target/sparc/vis_helper.c | 4 +-
> tcg/tcg-op.c | 4 +-
> tcg/tcg.c | 12 +++---
> tests/qtest/vhost-user-blk-test.c | 2 +-
> tests/qtest/virtio-blk-test.c | 2 +-
> ui/vdagent.c | 2 +-
> ui/vnc.c | 2 +-
> util/bitmap.c | 2 +-
> util/host-utils.c | 2 +-
> target/ppc/translate/vmx-impl.c.inc | 4 +-
> target/ppc/translate/vsx-impl.c.inc | 2 +-
> target/riscv/insn_trans/trans_rvv.c.inc | 4 +-
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> tcg/aarch64/tcg-target.c.inc | 4 +-
> tcg/arm/tcg-target.c.inc | 4 +-
> tcg/mips/tcg-target.c.inc | 2 +-
> tcg/ppc/tcg-target.c.inc | 10 ++---
> tcg/riscv/tcg-target.c.inc | 4 +-
> 85 files changed, 173 insertions(+), 173 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index f20712cb93d7..88df1bc42973 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1591,7 +1591,6 @@ config_host_data.set('QEMU_VERSION_MICRO', meson.project_version().split('.')[2]
>
> config_host_data.set_quoted('CONFIG_HOST_DSOSUF', host_dsosuf)
> config_host_data.set('HAVE_HOST_BLOCK_DEVICE', have_host_block_device)
> -config_host_data.set('HOST_WORDS_BIGENDIAN', host_machine.endian() == 'big')
Can we poison HOST_WORDS_BIGENDIAN definition to force cleaning old
patches before merging them?
next prev parent reply other threads:[~2022-03-16 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 9:53 [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN marcandre.lureau
2022-03-16 10:28 ` Thomas Huth
2022-03-16 11:15 ` Halil Pasic
2022-03-16 11:20 ` Marc-André Lureau
2022-03-16 11:22 ` Thomas Huth
2022-03-16 11:31 ` Halil Pasic
2022-03-16 13:04 ` Philippe Mathieu-Daudé [this message]
2022-03-16 13:09 ` Marc-André Lureau
2022-03-16 13:11 ` Philippe Mathieu-Daudé
2022-03-17 11:31 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e709547a-a0c2-d1bd-7145-d03e9fd1776a@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=Coiby.Xu@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bin.meng@windriver.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=farman@linux.ibm.com \
--cc=fnu.vikram@xilinx.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).