From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eK59C-0004LO-MX for qemu-devel@nongnu.org; Wed, 29 Nov 2017 11:23:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eK59B-0003iw-Uo for qemu-devel@nongnu.org; Wed, 29 Nov 2017 11:23:42 -0500 References: <20171123020832.8165-1-mreitz@redhat.com> <20171123020832.8165-3-mreitz@redhat.com> From: Eric Blake Message-ID: Date: Wed, 29 Nov 2017 10:23:27 -0600 MIME-Version: 1.0 In-Reply-To: <20171123020832.8165-3-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/17] qcow2: No persistent dirty bitmaps for compat=0.10 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Fam Zheng , John Snow , qemu-devel@nongnu.org On 11/22/2017 08:08 PM, Max Reitz wrote: > Persistent dirty bitmaps require a properly functioning > autoclear_features field, or we cannot track when an unsupporting > program might overwrite them. Therefore, we cannot support them for > compat=0.10 images. > > Signed-off-by: Max Reitz > --- > block/qcow2-bitmap.c | 10 ++++++++++ > block/qcow2.c | 14 +++++++++++--- > 2 files changed, 21 insertions(+), 3 deletions(-) Missed Kevin's latest -rc3 pull request; oh well. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org