From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83013C433E1 for ; Fri, 14 Aug 2020 10:56:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E92920866 for ; Fri, 14 Aug 2020 10:56:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="X0pThkKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E92920866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XNV-0005fo-I1 for qemu-devel@archiver.kernel.org; Fri, 14 Aug 2020 06:56:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6WIp-0007oD-H0; Fri, 14 Aug 2020 05:47:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:61390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6WIm-0007UV-0S; Fri, 14 Aug 2020 05:47:11 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07E9WtLY171287; Fri, 14 Aug 2020 05:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=xJSH3MsHT0oVSSkb25NXXwPLdnJwqAlcmfnp0r2Q7pI=; b=X0pThkKnRKijt4f/mdZ2er3IPHnGbYyWIr5sNJtUh7xq29K6WCXcd1nygR65pMFXhHet R8EPF+agP/M1wUA2333Ca/pySFkGuUFub4aYOIpgsBgxSgjjtOZE5RfsUe0MIu7azTVM jC8cd24hx7z6Dqw2kh4ZHuKjDiq6RJvFQePcHO9J1sknNYkI7Em46Aqg1NtnvU756HWO SOcUZealhMejiLlaG2id0tJo2vIyR05Zo35oQlj4saQXmklPbedFrL5U3jchNTi9qFTy q1AJb+NnR+XfScT0VABDVBzJ7AyinTjLQwF/nP6T5uOjILZMCctsnPTSSFWaRGomxrV3 BA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 32t93u3rnq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Aug 2020 05:46:58 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07E9X3H2171605; Fri, 14 Aug 2020 05:46:57 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 32t93u3rn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Aug 2020 05:46:57 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07E9fBRa024393; Fri, 14 Aug 2020 09:46:56 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 32skp8efk3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Aug 2020 09:46:55 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07E9krRr31588706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Aug 2020 09:46:53 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11F5552052; Fri, 14 Aug 2020 09:46:53 +0000 (GMT) Received: from oc3016276355.ibm.com (unknown [9.145.24.25]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 90D6D52050; Fri, 14 Aug 2020 09:46:52 +0000 (GMT) Subject: Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group() To: Pan Nengyuan , qemu-devel@nongnu.org References: <20200814160241.7915-1-pannengyuan@huawei.com> <20200814160241.7915-3-pannengyuan@huawei.com> From: Pierre Morel Message-ID: Date: Fri, 14 Aug 2020 11:46:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200814160241.7915-3-pannengyuan@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-14_04:2020-08-14, 2020-08-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=2 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008140073 Received-SPF: pass client-ip=148.163.158.5; envelope-from=pmorel@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 05:47:05 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Thomas Huth , zhang.zhanghailiang@huawei.com, Cornelia Huck , qemu-s390x@nongnu.org, Halil Pasic , Christian Borntraeger , Alex Williamson , euler.robot@huawei.com, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020-08-14 18:02, Pan Nengyuan wrote: > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Christian Borntraeger > Cc: Tony Krowiak > Cc: Halil Pasic > Cc: Pierre Morel > Cc: Alex Williamson > Cc: qemu-s390x@nongnu.org > --- > hw/vfio/ap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index b9330a8e6f..cec6fe1599 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -71,6 +71,7 @@ static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) > if (!group_path) { > error_setg(errp, "%s: no iommu_group found for %s: %s", > VFIO_AP_DEVICE_TYPE, vapdev->vdev.sysfsdev, gerror->message); > + g_error_free(gerror); > return NULL; > } > > Thanks Pan, Reviewed-by: Pierre Morel -- Pierre Morel IBM Lab Boeblingen