Re: [PATCH] tests/tcg/s390x: Use a different PCRel32 notation in branch-relative-long.c

[Thomas Huth <thuth@redhat.com>]

On 03/05/2022 11.02, Thomas Huth wrote:
> On 02/05/2022 18.48, Ilya Leoshkevich wrote:
>> Binutils >=2.37 and Clang do not accept (. - 0x100000000) PCRel32
>> constants. While this looks like a bug that needs fixing, use a
>> different notation (-0x100000000) as a workaround.
>>
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
>> ---
>>   tests/tcg/s390x/branch-relative-long.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/tcg/s390x/branch-relative-long.c 
>> b/tests/tcg/s390x/branch-relative-long.c
>> index 94219afcad..8ce9f1c2e5 100644
>> --- a/tests/tcg/s390x/branch-relative-long.c
>> +++ b/tests/tcg/s390x/branch-relative-long.c
>> @@ -13,8 +13,8 @@
>>           #_name "_end:\n");
>>   DEFINE_ASM(br_r14, "br %r14");
>> -DEFINE_ASM(brasl_r0, "brasl %r0,.-0x100000000");
>> -DEFINE_ASM(brcl_0xf, "brcl 0xf,.-0x100000000");
>> +DEFINE_ASM(brasl_r0, "brasl %r0,-0x100000000");
>> +DEFINE_ASM(brcl_0xf, "brcl 0xf,-0x100000000");
> 
> Works for me, thanks!

Sorry, I spoke too soon - it compiles fine, and also runs fine when I run it 
natively, but when I run it through "qemu-s390x", it crashes... does that 
work for you?

  Thomas