From: Tao Xu <tao3.xu@intel.com>
To: Eric Blake <eblake@redhat.com>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>,
"Liu, Jingqi" <jingqi.liu@intel.com>,
"Du, Fan" <fan.du@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
"imammedo@redhat.com" <imammedo@redhat.com>
Subject: Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
Date: Wed, 23 Oct 2019 09:50:44 +0800 [thread overview]
Message-ID: <e72312ca-86cc-08f7-95fb-102ba45b99e5@intel.com> (raw)
In-Reply-To: <7a0662f5-28e3-4bb8-0b20-669d34cf56a6@redhat.com>
On 10/23/2019 9:13 AM, Eric Blake wrote:
> On 10/20/19 6:11 AM, Tao Xu wrote:
>> To convert strings with time suffixes to numbers, support time unit are
>> "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms"
>> for millisecond or "s" for second.
>
> I haven't yet reviewed the patch itself, but my off-hand observation:
>
> picosecond is probably too narrow to ever be useful. POSIX interfaces
> only go down to nanoseconds, and when you start adding in vmexit delay
> times and such, we're lucky when we get anything better than microsecond
> accuracies. Supporting just three sub-second suffixes instead of four
> would slightly simplify the code, and not cost you any real precision.
>
Thank you for your suggestion.
next prev parent reply other threads:[~2019-10-23 1:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 11:11 [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT) Tao Xu
2019-10-20 11:11 ` [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps() Tao Xu
2019-10-23 1:08 ` Eduardo Habkost
2019-10-23 6:07 ` Tao Xu
2019-10-23 1:13 ` Eric Blake
2019-10-23 1:50 ` Tao Xu [this message]
2019-10-24 9:54 ` Daniel P. Berrangé
2019-10-24 13:20 ` Eduardo Habkost
2019-10-25 1:22 ` Tao Xu
2019-10-20 11:11 ` [PATCH v13 02/12] tests/cutils: Add test for qemu_strtotime_ps() Tao Xu
2019-10-20 11:11 ` [PATCH v13 03/12] qapi: Add builtin type time Tao Xu
2019-10-20 11:11 ` [PATCH v13 04/12] tests: Add test for QAPI " Tao Xu
2019-10-20 11:11 ` [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes Tao Xu
2019-10-21 12:29 ` Igor Mammedov
2019-10-22 1:01 ` Tao Xu
2019-10-20 11:11 ` [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information Tao Xu
2019-10-22 7:08 ` Igor Mammedov
2019-10-22 8:22 ` Tao Xu
2019-10-23 15:28 ` Igor Mammedov
2019-10-25 6:33 ` Tao Xu
2019-10-25 13:27 ` Igor Mammedov
2019-10-25 19:44 ` Markus Armbruster
2019-10-25 20:51 ` Eduardo Habkost
2019-10-28 2:05 ` Tao Xu
2019-10-28 5:46 ` Markus Armbruster
2019-10-28 7:25 ` Tao Xu
2019-10-20 11:11 ` [PATCH v13 07/12] numa: Calculate hmat latency and bandwidth entry list Tao Xu
2019-10-20 11:11 ` [PATCH v13 08/12] numa: Extend CLI to provide memory side cache information Tao Xu
2019-10-20 11:11 ` [PATCH v13 09/12] hmat acpi: Build Memory Proximity Domain Attributes Structure(s) Tao Xu
2019-10-20 11:11 ` [PATCH v13 10/12] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s) Tao Xu
2019-10-20 11:11 ` [PATCH v13 11/12] hmat acpi: Build Memory Side Cache " Tao Xu
2019-10-20 11:11 ` [PATCH v13 12/12] tests/bios-tables-test: add test cases for ACPI HMAT Tao Xu
2019-10-20 11:43 ` [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT) no-reply
2019-10-20 12:13 ` no-reply
2019-10-20 12:57 ` no-reply
2019-10-20 13:19 ` no-reply
2019-10-22 11:22 ` Markus Armbruster
2019-10-23 1:46 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72312ca-86cc-08f7-95fb-102ba45b99e5@intel.com \
--to=tao3.xu@intel.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fan.du@intel.com \
--cc=imammedo@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).