From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 3/5] target/s390x: Rework program_interrupt() and related functions
Date: Mon, 24 Jul 2017 20:09:08 +0200 [thread overview]
Message-ID: <e73044f6-c85e-38a5-b232-5a112d22d55f@redhat.com> (raw)
In-Reply-To: <1500886370-14572-4-git-send-email-thuth@redhat.com>
On 24.07.2017 10:52, Thomas Huth wrote:
> misc_helper.c won't be compiled with --disable-tcg anymore, but we
> still need the program_interrupt() function in that case. Move it
> to interrupt.c instead, and refactor it to re-use the code from
> trigger_pgm_exception() (for TCG) and enter_pgmcheck() (for KVM,
> which now got renamed to kvm_s390_program_interrupt() for
> clarity).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
I like that! Looks good to me!
--
Thanks,
David
next prev parent reply other threads:[~2017-07-24 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 8:52 [Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build with --disable-tcg Thomas Huth
2017-07-24 8:52 ` [Qemu-devel] [PATCH v3 1/5] target/s390x: Move s390_cpu_dump_state() to helper.c Thomas Huth
2017-07-24 8:52 ` [Qemu-devel] [PATCH v3 2/5] target/s390x: Move diag helpers to a separate file Thomas Huth
2017-07-24 8:52 ` [Qemu-devel] [PATCH v3 3/5] target/s390x: Rework program_interrupt() and related functions Thomas Huth
2017-07-24 15:11 ` Richard Henderson
2017-07-24 18:09 ` David Hildenbrand [this message]
2017-07-24 8:52 ` [Qemu-devel] [PATCH v3 4/5] target/s390x: Move exception-related functions to a new excp_helper.c file Thomas Huth
2017-07-24 8:52 ` [Qemu-devel] [PATCH v3 5/5] target/s390x: Add remaining switches to compile with --disable-tcg Thomas Huth
2017-07-24 11:32 ` [Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build " Cornelia Huck
2017-07-24 15:13 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e73044f6-c85e-38a5-b232-5a112d22d55f@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).