From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: avoid broken pipe with certtool
Date: Tue, 19 Feb 2019 10:37:05 -0600 [thread overview]
Message-ID: <e7382859-c57f-4de9-e0d1-b69ccc19f71d@redhat.com> (raw)
In-Reply-To: <20190219162114.GQ7154@redhat.com>
On 2/19/19 10:21 AM, Daniel P. Berrangé wrote:
>>> +tls_certtool()
>>> +{
>>> + certtool "$@" 1>certtool.log 2>&1
>>> + if test "$?" = 0; then
>>> + head -1 certtool.log
>>> + else
>>> + cat certtool.log
>>> + fi
>>> + rm -f certtool.log
>>> +}
>>
>> I assume this is running in a unique directory so that there can not be
>> a clash with a test running in parallel? Otherwise I'd recommend an
>> mktemp file name here...
>
> Hmm, could be a problem. Whatever happened to the plan to make every
> iotests run in a private directory ? Did that ever get done ?
Nope, still not done :(
Jeff left Red Hat, and so far no one else has revived his series.
Volunteers?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-19 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:13 [Qemu-devel] [PATCH 0/2] Fix NBD TLS iotests on RHEL-7 Daniel P. Berrangé
2019-02-19 16:13 ` [Qemu-devel] [PATCH 1/2] iotests: ensure we print nbd server log on error Daniel P. Berrangé
2019-02-19 16:35 ` Eric Blake
2019-02-19 16:13 ` [Qemu-devel] [PATCH 2/2] iotests: avoid broken pipe with certtool Daniel P. Berrangé
2019-02-19 16:19 ` Thomas Huth
2019-02-19 16:21 ` Daniel P. Berrangé
2019-02-19 16:37 ` Eric Blake [this message]
2019-02-19 16:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7382859-c57f-4de9-e0d1-b69ccc19f71d@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).