qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
	philippe@mathieu-daude.net, Eduardo Habkost <ehabkost@redhat.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function
Date: Thu, 13 Jul 2017 06:43:48 -0500	[thread overview]
Message-ID: <e73b3f52-c950-4fa3-cddd-0fd579a11108@redhat.com> (raw)
In-Reply-To: <878tjsr38n.fsf@dusky.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On 07/13/2017 06:22 AM, Markus Armbruster wrote:
>>>> I can take this through my tree once PATCH 4 got some R-by from PC
>>>> paintainers.  Whom you again neglected to cc; I just did that for you.
>>>> I'll be happy to touch up minor issues like the ones I pointed out for
>>>> v4.
>>>
>>> Thanks for CCing them. I keep assuming git send-email will CC from the
>>> suggested-by line, but apparently not.
>>
>> It will, if you add 'git config sendemail.cccmd
>> "/path/to/scripts/get_maintainer.pl --nogit-fallback --noroles"'
> 
> Misunderstanding?  Your bit of configuration automates cc'ing
> maintainers.  Alistair was wondering about Suggested-by lines.

Indeed. Unless someone submits a patch to upstream git, right now there
is only a finite set of 'Tag: <email@example.com>' that git will
automatically cc (including Signed-off-by: and CC:, but excluding
Suggested-by:).  It might be nice if git could add a knob to select
which Tag:s are important (or just relax its regular expression to send
CC:s to everything that looks like a Tag:).  But for now, adding ccs to
suggested-by requires manual effort.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-07-13 11:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 13:57 [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function Alistair Francis
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 1/7] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 2/7] error: Functions to report warnings and informational messages Alistair Francis
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 3/7] Convert error_report() to warn_report() Alistair Francis
2017-07-12 16:18   ` Markus Armbruster
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning messages Alistair Francis
2017-07-12 16:32   ` Markus Armbruster
2017-07-12 16:47   ` [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning messages, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Eduardo Habkost <ehabkost@redhat.com> Markus Armbruster
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 5/7] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 6/7] error: Implement the warn and free Error functions Alistair Francis
2017-07-12 13:57 ` [Qemu-devel] [PATCH v4 7/7] Convert error_report*_err() to warn_report*_err() Alistair Francis
2017-07-12 15:14 ` [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function no-reply
2017-07-12 16:49 ` Markus Armbruster
2017-07-13  7:08   ` Alistair Francis
2017-07-13 10:33     ` Eric Blake
2017-07-13 11:22       ` Markus Armbruster
2017-07-13 11:43         ` Eric Blake [this message]
2017-07-12 17:13 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e73b3f52-c950-4fa3-cddd-0fd579a11108@redhat.com \
    --to=eblake@redhat.com \
    --cc=alistair.francis@xilinx.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=philippe@mathieu-daude.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).