From: Stefan Markovic <smarkovic@wavecomp.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "aurelien@aurel32.net" <aurelien@aurel32.net>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"jancraig@amazon.com" <jancraig@amazon.com>,
Aleksandar Markovic <amarkovic@wavecomp.com>,
Petar Jovanovic <pjovanovic@wavecomp.com>
Subject: Re: [Qemu-devel] [PATCH v7 19/20] target/mips: Move MXU_EN check one level higher
Date: Fri, 26 Oct 2018 09:53:03 +0000 [thread overview]
Message-ID: <e7456394-a945-2d3b-517c-276de63c0eb9@wavecomp.com> (raw)
In-Reply-To: <1540383527-7923-20-git-send-email-aleksandar.markovic@rt-rk.com>
On 24.10.18. 14:18, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Move MXU_EN check to the main MXU decoding function, to avoid code
> repetition.
>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
> target/mips/translate.c | 509 ++++++++++++++++++++++--------------------------
> 1 file changed, 238 insertions(+), 271 deletions(-)
Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 61c1662..3620ae5 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -23960,23 +23960,16 @@ static void gen_mxu_s32m2i(DisasContext *ctx)
> static void gen_mxu_s8ldd(DisasContext *ctx)
> {
> TCGv t0, t1;
> - TCGLabel *l0;
> uint32_t XRa, Rb, s8, optn3;
>
> t0 = tcg_temp_new();
> t1 = tcg_temp_new();
>
> - l0 = gen_new_label();
> -
> XRa = extract32(ctx->opcode, 6, 4);
> s8 = extract32(ctx->opcode, 10, 8);
> optn3 = extract32(ctx->opcode, 18, 3);
> Rb = extract32(ctx->opcode, 21, 5);
>
> - gen_load_mxu_cr(t0);
> - tcg_gen_andi_tl(t0, t0, MXU_CR_MXU_EN);
> - tcg_gen_brcondi_tl(TCG_COND_NE, t0, MXU_CR_MXU_EN, l0);
> -
> gen_load_gpr(t0, Rb);
> tcg_gen_addi_tl(t0, t0, (int8_t)s8);
>
> @@ -24034,8 +24027,6 @@ static void gen_mxu_s8ldd(DisasContext *ctx)
>
> gen_store_mxu_gpr(t0, XRa);
>
> - gen_set_label(l0);
> -
> tcg_temp_free(t0);
> tcg_temp_free(t1);
> }
> @@ -24046,7 +24037,6 @@ static void gen_mxu_s8ldd(DisasContext *ctx)
> static void gen_mxu_d16mul(DisasContext *ctx)
> {
> TCGv t0, t1, t2, t3;
> - TCGLabel *l0;
> uint32_t XRa, XRb, XRc, XRd, optn2;
>
> t0 = tcg_temp_new();
> @@ -24054,18 +24044,12 @@ static void gen_mxu_d16mul(DisasContext *ctx)
> t2 = tcg_temp_new();
> t3 = tcg_temp_new();
>
> - l0 = gen_new_label();
> -
> XRa = extract32(ctx->opcode, 6, 4);
> XRb = extract32(ctx->opcode, 10, 4);
> XRc = extract32(ctx->opcode, 14, 4);
> XRd = extract32(ctx->opcode, 18, 4);
> optn2 = extract32(ctx->opcode, 22, 2);
>
> - gen_load_mxu_cr(t0);
> - tcg_gen_andi_tl(t0, t0, MXU_CR_MXU_EN);
> - tcg_gen_brcondi_tl(TCG_COND_NE, t0, MXU_CR_MXU_EN, l0);
> -
> gen_load_mxu_gpr(t1, XRb);
> tcg_gen_sextract_tl(t0, t1, 0, 16);
> tcg_gen_sextract_tl(t1, t1, 16, 16);
> @@ -24094,8 +24078,6 @@ static void gen_mxu_d16mul(DisasContext *ctx)
> gen_store_mxu_gpr(t3, XRa);
> gen_store_mxu_gpr(t2, XRd);
>
> - gen_set_label(l0);
> -
> tcg_temp_free(t0);
> tcg_temp_free(t1);
> tcg_temp_free(t2);
> @@ -24109,7 +24091,6 @@ static void gen_mxu_d16mul(DisasContext *ctx)
> static void gen_mxu_d16mac(DisasContext *ctx)
> {
> TCGv t0, t1, t2, t3;
> - TCGLabel *l0;
> uint32_t XRa, XRb, XRc, XRd, optn2, aptn2;
>
> t0 = tcg_temp_new();
> @@ -24117,8 +24098,6 @@ static void gen_mxu_d16mac(DisasContext *ctx)
> t2 = tcg_temp_new();
> t3 = tcg_temp_new();
>
> - l0 = gen_new_label();
> -
> XRa = extract32(ctx->opcode, 6, 4);
> XRb = extract32(ctx->opcode, 10, 4);
> XRc = extract32(ctx->opcode, 14, 4);
> @@ -24126,10 +24105,6 @@ static void gen_mxu_d16mac(DisasContext *ctx)
> optn2 = extract32(ctx->opcode, 22, 2);
> aptn2 = extract32(ctx->opcode, 24, 2);
>
> - gen_load_mxu_cr(t0);
> - tcg_gen_andi_tl(t0, t0, MXU_CR_MXU_EN);
> - tcg_gen_brcondi_tl(TCG_COND_NE, t0, MXU_CR_MXU_EN, l0);
> -
> gen_load_mxu_gpr(t1, XRb);
> tcg_gen_sextract_tl(t0, t1, 0, 16);
> tcg_gen_sextract_tl(t1, t1, 16, 16);
> @@ -24180,8 +24155,6 @@ static void gen_mxu_d16mac(DisasContext *ctx)
> gen_store_mxu_gpr(t3, XRa);
> gen_store_mxu_gpr(t2, XRd);
>
> - gen_set_label(l0);
> -
> tcg_temp_free(t0);
> tcg_temp_free(t1);
> tcg_temp_free(t2);
> @@ -24195,7 +24168,6 @@ static void gen_mxu_d16mac(DisasContext *ctx)
> static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx)
> {
> TCGv t0, t1, t2, t3, t4, t5, t6, t7;
> - TCGLabel *l0;
> uint32_t XRa, XRb, XRc, XRd, sel;
>
> t0 = tcg_temp_new();
> @@ -24207,18 +24179,12 @@ static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx)
> t6 = tcg_temp_new();
> t7 = tcg_temp_new();
>
> - l0 = gen_new_label();
> -
> XRa = extract32(ctx->opcode, 6, 4);
> XRb = extract32(ctx->opcode, 10, 4);
> XRc = extract32(ctx->opcode, 14, 4);
> XRd = extract32(ctx->opcode, 18, 4);
> sel = extract32(ctx->opcode, 22, 2);
>
> - gen_load_mxu_cr(t0);
> - tcg_gen_andi_tl(t0, t0, MXU_CR_MXU_EN);
> - tcg_gen_brcondi_tl(TCG_COND_NE, t0, MXU_CR_MXU_EN, l0);
> -
> gen_load_mxu_gpr(t3, XRb);
> gen_load_mxu_gpr(t7, XRc);
>
> @@ -24269,8 +24235,6 @@ static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx)
> gen_store_mxu_gpr(t0, XRd);
> gen_store_mxu_gpr(t1, XRa);
>
> - gen_set_label(l0);
> -
> tcg_temp_free(t0);
> tcg_temp_free(t1);
> tcg_temp_free(t2);
> @@ -24288,23 +24252,16 @@ static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx)
> static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx)
> {
> TCGv t0, t1;
> - TCGLabel *l0;
> uint32_t XRa, Rb, s12, sel;
>
> t0 = tcg_temp_new();
> t1 = tcg_temp_new();
>
> - l0 = gen_new_label();
> -
> XRa = extract32(ctx->opcode, 6, 4);
> s12 = extract32(ctx->opcode, 10, 10);
> sel = extract32(ctx->opcode, 20, 1);
> Rb = extract32(ctx->opcode, 21, 5);
>
> - gen_load_mxu_cr(t0);
> - tcg_gen_andi_tl(t0, t0, MXU_CR_MXU_EN);
> - tcg_gen_brcondi_tl(TCG_COND_NE, t0, MXU_CR_MXU_EN, l0);
> -
> gen_load_gpr(t0, Rb);
>
> tcg_gen_movi_tl(t1, s12);
> @@ -24321,8 +24278,6 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx)
> }
> gen_store_mxu_gpr(t1, XRa);
>
> - gen_set_label(l0);
> -
> tcg_temp_free(t0);
> tcg_temp_free(t1);
> }
> @@ -25243,232 +25198,244 @@ static void decode_opc_mxu(CPUMIPSState *env, DisasContext *ctx)
> return;
> }
>
> - switch (opcode) {
> - case OPC_MXU_S32MADD:
> - /* TODO: Implement emulation of S32MADD instruction. */
> - MIPS_INVAL("OPC_MXU_S32MADD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S32MADDU:
> - /* TODO: Implement emulation of S32MADDU instruction. */
> - MIPS_INVAL("OPC_MXU_S32MADDU");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL00:
> - decode_opc_mxu__pool00(env, ctx);
> - break;
> - case OPC_MXU_S32MSUB:
> - /* TODO: Implement emulation of S32MSUB instruction. */
> - MIPS_INVAL("OPC_MXU_S32MSUB");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S32MSUBU:
> - /* TODO: Implement emulation of S32MSUBU instruction. */
> - MIPS_INVAL("OPC_MXU_S32MSUBU");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL01:
> - decode_opc_mxu__pool01(env, ctx);
> - break;
> - case OPC_MXU__POOL02:
> - decode_opc_mxu__pool02(env, ctx);
> - break;
> - case OPC_MXU_D16MUL:
> - gen_mxu_d16mul(ctx);
> - break;
> - case OPC_MXU__POOL03:
> - decode_opc_mxu__pool03(env, ctx);
> - break;
> - case OPC_MXU_D16MAC:
> - gen_mxu_d16mac(ctx);
> - break;
> - case OPC_MXU_D16MACF:
> - /* TODO: Implement emulation of D16MACF instruction. */
> - MIPS_INVAL("OPC_MXU_D16MACF");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D16MADL:
> - /* TODO: Implement emulation of D16MADL instruction. */
> - MIPS_INVAL("OPC_MXU_D16MADL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S16MAD:
> - /* TODO: Implement emulation of S16MAD instruction. */
> - MIPS_INVAL("OPC_MXU_S16MAD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_Q16ADD:
> - /* TODO: Implement emulation of Q16ADD instruction. */
> - MIPS_INVAL("OPC_MXU_Q16ADD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D16MACE:
> - /* TODO: Implement emulation of D16MACE instruction. */
> - MIPS_INVAL("OPC_MXU_D16MACE");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL04:
> - decode_opc_mxu__pool04(env, ctx);
> - break;
> - case OPC_MXU__POOL05:
> - decode_opc_mxu__pool05(env, ctx);
> - break;
> - case OPC_MXU__POOL06:
> - decode_opc_mxu__pool06(env, ctx);
> - break;
> - case OPC_MXU__POOL07:
> - decode_opc_mxu__pool07(env, ctx);
> - break;
> - case OPC_MXU__POOL08:
> - decode_opc_mxu__pool08(env, ctx);
> - break;
> - case OPC_MXU__POOL09:
> - decode_opc_mxu__pool09(env, ctx);
> - break;
> - case OPC_MXU__POOL10:
> - decode_opc_mxu__pool10(env, ctx);
> - break;
> - case OPC_MXU__POOL11:
> - decode_opc_mxu__pool11(env, ctx);
> - break;
> - case OPC_MXU_D32ADD:
> - /* TODO: Implement emulation of D32ADD instruction. */
> - MIPS_INVAL("OPC_MXU_D32ADD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL12:
> - decode_opc_mxu__pool12(env, ctx);
> - break;
> - case OPC_MXU__POOL13:
> - decode_opc_mxu__pool13(env, ctx);
> - break;
> - case OPC_MXU__POOL14:
> - decode_opc_mxu__pool14(env, ctx);
> - break;
> - case OPC_MXU_Q8ACCE:
> - /* TODO: Implement emulation of Q8ACCE instruction. */
> - MIPS_INVAL("OPC_MXU_Q8ACCE");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S8LDD:
> - gen_mxu_s8ldd(ctx);
> - break;
> - case OPC_MXU_S8STD:
> - /* TODO: Implement emulation of S8STD instruction. */
> - MIPS_INVAL("OPC_MXU_S8STD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S8LDI:
> - /* TODO: Implement emulation of S8LDI instruction. */
> - MIPS_INVAL("OPC_MXU_S8LDI");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S8SDI:
> - /* TODO: Implement emulation of S8SDI instruction. */
> - MIPS_INVAL("OPC_MXU_S8SDI");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL15:
> - decode_opc_mxu__pool15(env, ctx);
> - break;
> - case OPC_MXU__POOL16:
> - decode_opc_mxu__pool16(env, ctx);
> - break;
> - case OPC_MXU_LXB:
> - /* TODO: Implement emulation of LXB instruction. */
> - MIPS_INVAL("OPC_MXU_LXB");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S16LDD:
> - /* TODO: Implement emulation of S16LDD instruction. */
> - MIPS_INVAL("OPC_MXU_S16LDD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S16STD:
> - /* TODO: Implement emulation of S16STD instruction. */
> - MIPS_INVAL("OPC_MXU_S16STD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S16LDI:
> - /* TODO: Implement emulation of S16LDI instruction. */
> - MIPS_INVAL("OPC_MXU_S16LDI");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S16SDI:
> - /* TODO: Implement emulation of S16SDI instruction. */
> - MIPS_INVAL("OPC_MXU_S16SDI");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D32SLL:
> - /* TODO: Implement emulation of D32SLL instruction. */
> - MIPS_INVAL("OPC_MXU_D32SLL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D32SLR:
> - /* TODO: Implement emulation of D32SLR instruction. */
> - MIPS_INVAL("OPC_MXU_D32SLR");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D32SARL:
> - /* TODO: Implement emulation of D32SARL instruction. */
> - MIPS_INVAL("OPC_MXU_D32SARL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_D32SAR:
> - /* TODO: Implement emulation of D32SAR instruction. */
> - MIPS_INVAL("OPC_MXU_D32SAR");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_Q16SLL:
> - /* TODO: Implement emulation of Q16SLL instruction. */
> - MIPS_INVAL("OPC_MXU_Q16SLL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_Q16SLR:
> - /* TODO: Implement emulation of Q16SLR instruction. */
> - MIPS_INVAL("OPC_MXU_Q16SLR");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL17:
> - decode_opc_mxu__pool17(env, ctx);
> - break;
> - case OPC_MXU_Q16SAR:
> - /* TODO: Implement emulation of Q16SAR instruction. */
> - MIPS_INVAL("OPC_MXU_Q16SAR");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU__POOL18:
> - decode_opc_mxu__pool18(env, ctx);
> - break;
> - case OPC_MXU__POOL19:
> - decode_opc_mxu__pool19(env, ctx);
> - break;
> - case OPC_MXU__POOL20:
> - decode_opc_mxu__pool20(env, ctx);
> - break;
> - case OPC_MXU_Q16SCOP:
> - /* TODO: Implement emulation of Q16SCOP instruction. */
> - MIPS_INVAL("OPC_MXU_Q16SCOP");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_Q8MADL:
> - /* TODO: Implement emulation of Q8MADL instruction. */
> - MIPS_INVAL("OPC_MXU_Q8MADL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_S32SFL:
> - /* TODO: Implement emulation of S32SFL instruction. */
> - MIPS_INVAL("OPC_MXU_S32SFL");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - case OPC_MXU_Q8SAD:
> - /* TODO: Implement emulation of Q8SAD instruction. */
> - MIPS_INVAL("OPC_MXU_Q8SAD");
> - generate_exception_end(ctx, EXCP_RI);
> - break;
> - default:
> - MIPS_INVAL("decode_opc_mxu");
> - generate_exception_end(ctx, EXCP_RI);
> + {
> + TCGv t_mxu_cr = tcg_temp_new();
> + TCGLabel *l_exit = gen_new_label();
> +
> + gen_load_mxu_cr(t_mxu_cr);
> + tcg_gen_andi_tl(t_mxu_cr, t_mxu_cr, MXU_CR_MXU_EN);
> + tcg_gen_brcondi_tl(TCG_COND_NE, t_mxu_cr, MXU_CR_MXU_EN, l_exit);
> +
> + switch (opcode) {
> + case OPC_MXU_S32MADD:
> + /* TODO: Implement emulation of S32MADD instruction. */
> + MIPS_INVAL("OPC_MXU_S32MADD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S32MADDU:
> + /* TODO: Implement emulation of S32MADDU instruction. */
> + MIPS_INVAL("OPC_MXU_S32MADDU");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL00:
> + decode_opc_mxu__pool00(env, ctx);
> + break;
> + case OPC_MXU_S32MSUB:
> + /* TODO: Implement emulation of S32MSUB instruction. */
> + MIPS_INVAL("OPC_MXU_S32MSUB");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S32MSUBU:
> + /* TODO: Implement emulation of S32MSUBU instruction. */
> + MIPS_INVAL("OPC_MXU_S32MSUBU");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL01:
> + decode_opc_mxu__pool01(env, ctx);
> + break;
> + case OPC_MXU__POOL02:
> + decode_opc_mxu__pool02(env, ctx);
> + break;
> + case OPC_MXU_D16MUL:
> + gen_mxu_d16mul(ctx);
> + break;
> + case OPC_MXU__POOL03:
> + decode_opc_mxu__pool03(env, ctx);
> + break;
> + case OPC_MXU_D16MAC:
> + gen_mxu_d16mac(ctx);
> + break;
> + case OPC_MXU_D16MACF:
> + /* TODO: Implement emulation of D16MACF instruction. */
> + MIPS_INVAL("OPC_MXU_D16MACF");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D16MADL:
> + /* TODO: Implement emulation of D16MADL instruction. */
> + MIPS_INVAL("OPC_MXU_D16MADL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S16MAD:
> + /* TODO: Implement emulation of S16MAD instruction. */
> + MIPS_INVAL("OPC_MXU_S16MAD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_Q16ADD:
> + /* TODO: Implement emulation of Q16ADD instruction. */
> + MIPS_INVAL("OPC_MXU_Q16ADD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D16MACE:
> + /* TODO: Implement emulation of D16MACE instruction. */
> + MIPS_INVAL("OPC_MXU_D16MACE");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL04:
> + decode_opc_mxu__pool04(env, ctx);
> + break;
> + case OPC_MXU__POOL05:
> + decode_opc_mxu__pool05(env, ctx);
> + break;
> + case OPC_MXU__POOL06:
> + decode_opc_mxu__pool06(env, ctx);
> + break;
> + case OPC_MXU__POOL07:
> + decode_opc_mxu__pool07(env, ctx);
> + break;
> + case OPC_MXU__POOL08:
> + decode_opc_mxu__pool08(env, ctx);
> + break;
> + case OPC_MXU__POOL09:
> + decode_opc_mxu__pool09(env, ctx);
> + break;
> + case OPC_MXU__POOL10:
> + decode_opc_mxu__pool10(env, ctx);
> + break;
> + case OPC_MXU__POOL11:
> + decode_opc_mxu__pool11(env, ctx);
> + break;
> + case OPC_MXU_D32ADD:
> + /* TODO: Implement emulation of D32ADD instruction. */
> + MIPS_INVAL("OPC_MXU_D32ADD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL12:
> + decode_opc_mxu__pool12(env, ctx);
> + break;
> + case OPC_MXU__POOL13:
> + decode_opc_mxu__pool13(env, ctx);
> + break;
> + case OPC_MXU__POOL14:
> + decode_opc_mxu__pool14(env, ctx);
> + break;
> + case OPC_MXU_Q8ACCE:
> + /* TODO: Implement emulation of Q8ACCE instruction. */
> + MIPS_INVAL("OPC_MXU_Q8ACCE");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S8LDD:
> + gen_mxu_s8ldd(ctx);
> + break;
> + case OPC_MXU_S8STD:
> + /* TODO: Implement emulation of S8STD instruction. */
> + MIPS_INVAL("OPC_MXU_S8STD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S8LDI:
> + /* TODO: Implement emulation of S8LDI instruction. */
> + MIPS_INVAL("OPC_MXU_S8LDI");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S8SDI:
> + /* TODO: Implement emulation of S8SDI instruction. */
> + MIPS_INVAL("OPC_MXU_S8SDI");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL15:
> + decode_opc_mxu__pool15(env, ctx);
> + break;
> + case OPC_MXU__POOL16:
> + decode_opc_mxu__pool16(env, ctx);
> + break;
> + case OPC_MXU_LXB:
> + /* TODO: Implement emulation of LXB instruction. */
> + MIPS_INVAL("OPC_MXU_LXB");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S16LDD:
> + /* TODO: Implement emulation of S16LDD instruction. */
> + MIPS_INVAL("OPC_MXU_S16LDD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S16STD:
> + /* TODO: Implement emulation of S16STD instruction. */
> + MIPS_INVAL("OPC_MXU_S16STD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S16LDI:
> + /* TODO: Implement emulation of S16LDI instruction. */
> + MIPS_INVAL("OPC_MXU_S16LDI");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S16SDI:
> + /* TODO: Implement emulation of S16SDI instruction. */
> + MIPS_INVAL("OPC_MXU_S16SDI");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D32SLL:
> + /* TODO: Implement emulation of D32SLL instruction. */
> + MIPS_INVAL("OPC_MXU_D32SLL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D32SLR:
> + /* TODO: Implement emulation of D32SLR instruction. */
> + MIPS_INVAL("OPC_MXU_D32SLR");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D32SARL:
> + /* TODO: Implement emulation of D32SARL instruction. */
> + MIPS_INVAL("OPC_MXU_D32SARL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_D32SAR:
> + /* TODO: Implement emulation of D32SAR instruction. */
> + MIPS_INVAL("OPC_MXU_D32SAR");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_Q16SLL:
> + /* TODO: Implement emulation of Q16SLL instruction. */
> + MIPS_INVAL("OPC_MXU_Q16SLL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_Q16SLR:
> + /* TODO: Implement emulation of Q16SLR instruction. */
> + MIPS_INVAL("OPC_MXU_Q16SLR");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL17:
> + decode_opc_mxu__pool17(env, ctx);
> + break;
> + case OPC_MXU_Q16SAR:
> + /* TODO: Implement emulation of Q16SAR instruction. */
> + MIPS_INVAL("OPC_MXU_Q16SAR");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU__POOL18:
> + decode_opc_mxu__pool18(env, ctx);
> + break;
> + case OPC_MXU__POOL19:
> + decode_opc_mxu__pool19(env, ctx);
> + break;
> + case OPC_MXU__POOL20:
> + decode_opc_mxu__pool20(env, ctx);
> + break;
> + case OPC_MXU_Q16SCOP:
> + /* TODO: Implement emulation of Q16SCOP instruction. */
> + MIPS_INVAL("OPC_MXU_Q16SCOP");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_Q8MADL:
> + /* TODO: Implement emulation of Q8MADL instruction. */
> + MIPS_INVAL("OPC_MXU_Q8MADL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_S32SFL:
> + /* TODO: Implement emulation of S32SFL instruction. */
> + MIPS_INVAL("OPC_MXU_S32SFL");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + case OPC_MXU_Q8SAD:
> + /* TODO: Implement emulation of Q8SAD instruction. */
> + MIPS_INVAL("OPC_MXU_Q8SAD");
> + generate_exception_end(ctx, EXCP_RI);
> + break;
> + default:
> + MIPS_INVAL("decode_opc_mxu");
> + generate_exception_end(ctx, EXCP_RI);
> + }
> +
> + gen_set_label(l_exit);
> + tcg_temp_free(t_mxu_cr);
> }
> }
>
next prev parent reply other threads:[~2018-10-26 9:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 12:18 [Qemu-devel] [PATCH v7 00/20] target/mips: Add limited support for Ingenic's MXU ASE Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 01/20] target/mips: Introduce MXU registers Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 02/20] target/mips: Define a bit for MXU in insn_flags Aleksandar Markovic
2018-10-28 18:05 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 03/20] target/mips: Amend MXU instruction opcodes Aleksandar Markovic
2018-10-25 8:31 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 04/20] target/mips: Add and integrate MXU decoding engine placeholder Aleksandar Markovic
2018-10-26 9:10 ` Stefan Markovic
2018-10-28 17:57 ` Aleksandar Markovic
2018-10-28 18:39 ` Aleksandar Markovic
2018-10-29 10:09 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 05/20] target/mips: Add MXU decoding engine Aleksandar Markovic
2018-10-26 9:13 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 06/20] target/mips: Add bit encoding for MXU accumulate add/sub 1-bit pattern 'aptn1' Aleksandar Markovic
2018-10-26 9:16 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 07/20] target/mips: Add bit encoding for MXU accumulate add/sub 2-bit pattern 'aptn2' Aleksandar Markovic
2018-10-28 17:37 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 08/20] target/mips: Add bit encoding for MXU execute add/sub pattern 'eptn2' Aleksandar Markovic
2018-10-26 9:17 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 09/20] target/mips: Add bit encoding for MXU operand getting pattern 'optn2' Aleksandar Markovic
2018-10-28 17:36 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 10/20] target/mips: Add bit encoding for MXU operand getting pattern 'optn3' Aleksandar Markovic
2018-10-28 17:35 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 11/20] target/mips: Add emulation of non-MXU MULL within MXU decoding engine Aleksandar Markovic
2018-10-28 18:20 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 12/20] target/mips: Add emulation of MXU instructions S32I2M and S32M2I Aleksandar Markovic
2018-10-28 18:19 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 13/20] target/mips: Move MUL, S32M2I, S32I2M handling out of main MXU switch Aleksandar Markovic
2018-10-26 9:45 ` Stefan Markovic
2018-10-29 10:12 ` Stefan Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 14/20] target/mips: Add emulation of MXU instruction S8LDD Aleksandar Markovic
2018-10-25 8:08 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 15/20] target/mips: Add emulation of MXU instruction D16MUL Aleksandar Markovic
2018-10-25 8:06 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 16/20] target/mips: Add emulation of MXU instruction D16MAC Aleksandar Markovic
2018-10-25 8:07 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 17/20] target/mips: Add emulation of MXU instructions Q8MUL and Q8MULSU Aleksandar Markovic
2018-10-25 8:09 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 18/20] target/mips: Add emulation of MXU instructions S32LDD and S32LDDR Aleksandar Markovic
2018-10-25 8:08 ` Aleksandar Markovic
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 19/20] target/mips: Move MXU_EN check one level higher Aleksandar Markovic
2018-10-26 9:53 ` Stefan Markovic [this message]
2018-10-24 12:18 ` [Qemu-devel] [PATCH v7 20/20] target/mips: Amend MXU ASE overview note Aleksandar Markovic
2018-10-26 9:56 ` Stefan Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7456394-a945-2d3b-517c-276de63c0eb9@wavecomp.com \
--to=smarkovic@wavecomp.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=jancraig@amazon.com \
--cc=pjovanovic@wavecomp.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).