From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: liq3ea@163.com
Subject: Re: [PATCH-for-5.1 1/2] configure: do not clobber CFLAGS with --enable-fuzzing
Date: Thu, 9 Jul 2020 07:01:14 +0200 [thread overview]
Message-ID: <e74e6719-c9cd-7004-cfc6-13a392cd803f@redhat.com> (raw)
In-Reply-To: <20200708200104.21978-2-alxndr@bu.edu>
On 7/8/20 10:01 PM, Alexander Bulekov wrote:
> When configuring with --enable-fuzzing, we overwrote the CFLAGS
> added by all the preceding checks. Instead of overwriting CFLAGS, append
> the ones we need.
>
> Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing")
> Reported-by: Li Qiang <liq3ea@163.com>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ee6c3c6792..078ebaa9f3 100755
> --- a/configure
> +++ b/configure
> @@ -7898,7 +7898,7 @@ if test "$fuzzing" = "yes" ; then
> if test "$have_fuzzer" = "yes"; then
> FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
> FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
> - CFLAGS=" -fsanitize=address,fuzzer-no-link"
> + CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"
> else
> error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
> exit 1
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-07-09 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:01 [PATCH-for-5.1 0/2] fuzz: broken build fixes Alexander Bulekov
2020-07-08 20:01 ` [PATCH-for-5.1 1/2] configure: do not clobber CFLAGS with --enable-fuzzing Alexander Bulekov
2020-07-08 23:49 ` Li Qiang
2020-07-09 5:01 ` Philippe Mathieu-Daudé [this message]
2020-07-08 20:01 ` [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork Alexander Bulekov
2020-07-09 5:03 ` Philippe Mathieu-Daudé
2020-07-09 5:09 ` Philippe Mathieu-Daudé
2020-07-09 5:15 ` Thomas Huth
2020-07-09 13:15 ` Philippe Mathieu-Daudé
2020-07-09 5:18 ` Thomas Huth
2020-07-09 13:38 ` Alexander Bulekov
2020-07-09 13:57 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e74e6719-c9cd-7004-cfc6-13a392cd803f@redhat.com \
--to=philmd@redhat.com \
--cc=alxndr@bu.edu \
--cc=liq3ea@163.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).