From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314FEC433E1 for ; Mon, 13 Jul 2020 07:39:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F072C20663 for ; Mon, 13 Jul 2020 07:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gigRzWrO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F072C20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jut3W-0002Ky-9U for qemu-devel@archiver.kernel.org; Mon, 13 Jul 2020 03:39:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jut2y-0001vx-I6 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 03:38:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49666 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jut2s-0000TK-W0 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 03:38:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594625917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=YP5kJEoO/Fd34p+WoQ8SUnnPhngoekXWnG61cmGd/AE=; b=gigRzWrOZY7/lrs7z6DECCbRYuaeDeyxmRMwSyHxCchmTJ26XPDC3Zw97zPu6Kl0bow/HY /I+99+r3FPjSNl6kP4wROS/3z7BZRAeUc2pSa1/OJJ3WK4Rj9NVWNr/6/2h4+aHT9DY6Vh vRUUuYx8qV8dZr7OrZ/cqfZqGjOF+Pg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-BEtlrYssNyem8oMZDIruwA-1; Mon, 13 Jul 2020 03:38:31 -0400 X-MC-Unique: BEtlrYssNyem8oMZDIruwA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E3D01800D42; Mon, 13 Jul 2020 07:38:30 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-125.ams2.redhat.com [10.36.112.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 447202B6DE; Mon, 13 Jul 2020 07:38:29 +0000 (UTC) Subject: Re: [PATCH] docs/system/s390x: Improve the 3270 documentation To: Cornelia Huck References: <20200709160439.15088-1-thuth@redhat.com> <20200710125552.1ad24571.cohuck@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: Date: Mon, 13 Jul 2020 09:38:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200710125552.1ad24571.cohuck@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 03:20:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/07/2020 12.55, Cornelia Huck wrote: > On Thu, 9 Jul 2020 18:04:39 +0200 > Thomas Huth wrote: > >> There is some additional information about the 3270 support in our >> Wiki at https://wiki.qemu.org/Features/3270 - so let's include this >> information into the main documentation now to have one single >> source of information (the Wiki page could later be removed). > > No objection; but what should our general policy with regard to wiki > pages vs. documentation be? The 3270 support is pretty much static, but > e.g. for vfio-ccw, we use the wiki page as a place where we track > things that should be worked on etc. I think that docs which are "done" should go into the git repo. If they are rather still work-in-progress and change very often, or relate to a feature that has not been merged yet, the wiki is likely the better place. > (Related: What is the scope of our QEMU documentation? Is a libvirt XML > snippet on topic? Kernel configuration options (as in here)?) As long as the focus is still on QEMU, I think it is fine. If the information is only about libvirt or the kernel, that documentation should maybe rather be added to libvirt.org or linux-kvm.org instead. >> Signed-off-by: Thomas Huth >> --- >> docs/system/s390x/3270.rst | 43 ++++++++++++++++++++++++++++++++------ >> 1 file changed, 37 insertions(+), 6 deletions(-) >> >> diff --git a/docs/system/s390x/3270.rst b/docs/system/s390x/3270.rst >> index 1774cdcadf..80350264d7 100644 >> --- a/docs/system/s390x/3270.rst >> +++ b/docs/system/s390x/3270.rst >> @@ -1,9 +1,15 @@ >> 3270 devices >> ============ >> >> -QEMU supports connecting an external 3270 terminal emulator (such as >> -``x3270``) to make a single 3270 device available to a guest. Note that this >> -supports basic features only. >> +The 3270 is the classic 'green-screen' console of the mainframes (see the >> +`IBM 3270 Wikipedia article `__). >> + >> +The 3270 data stream is not implemented within QEMU; the device only provides >> +TN3270 (a telnet extension; see `RFC 854 `__ >> +and `RFC 1576 `__) and leaves the heavy >> +lifting to an external 3270 terminal emulator (such as ``x3270``) to make a >> +single 3270 device available to a guest. Note that this supports basic >> +features only. >> >> To provide a 3270 device to a guest, create a ``x-terminal3270`` linked to >> a ``tn3270`` chardev. The guest will see a 3270 channel device. In order >> @@ -12,10 +18,14 @@ to actually be able to use it, attach the ``x3270`` emulator to the chardev. >> Example configuration >> --------------------- >> >> +* Make sure that 3270 support is enabled in the guest's kernel. You need >> + ``CONFIG_TN3270`` and at least one of ``CONFIG_TN3270_TTY`` (for additional >> + ttys) or ``CONFIG_TN3270_CONSOLE`` (for a 3270 console). >> + >> * Add a ``tn3270`` chardev and a ``x-terminal3270`` to the QEMU command line:: >> >> - -chardev socket,id=char_0,host=0.0.0.0,port=2300,nowait,server,tn3270 >> - -device x-terminal3270,chardev=char_0,devno=fe.0.000a,id=terminal_0 >> + -chardev socket,id=ch0,host=0.0.0.0,port=2300,nowait,server,tn3270 >> + -device x-terminal3270,chardev=ch0,devno=fe.0.000a,id=terminal0 > > Any reason why you changed this? The lines were too long - Firefox displayed this example with a horizontal scrollbar, even if I resized the browser window large enough. With my change, it shows up nicely without scrollbar. >> >> * Start the guest. In the guest, use ``chccwdev -e 0.0.000a`` to enable >> the device. >> @@ -29,4 +39,25 @@ Example configuration >> >> systemctl start serial-getty@3270-tty1.service >> >> -This should get you an addtional tty for logging into the guest. >> + This should get you an addtional tty for logging into the guest. >> + >> +* If you want to use the 3270 device as the kernel console instead of an >> + additional tty, you can also append ``conmode=3270 condev=000a`` to the >> + guest's kernel command line. The kernel then should use the 3270 as >> + console after the next boot. >> + >> +Restrictions >> +------------ >> + >> +3270 support is still experimental. In particular: > > s/still experimental/very basic/ > > I don't think there's much progress on the horizon; let's not give > people false hope :) > >> + >> +* Only one 3270 device is supported. >> + >> +* It has only been tested with Linux guests and the x3270 emulator. >> + >> +* TLS/SSL is not yet supported. > > s/yet // > >> + >> +* Resizing on reattach is not yet supported. > > s/yet // > >> + >> +* Multiple commands in one inbound buffer (for example, when the reset key >> + is pressed while the network is slow) are not yet supported. > > s/yet // > I'll fix these in v2. Thanks for the review! Thomas