* [PATCH] qemu-storage-daemon: Fix help line for --export
@ 2020-09-30 13:39 Kevin Wolf
2020-09-30 13:48 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2020-09-30 13:39 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel
Commit 5f479a8d renamed the 'device' option of --export into
'node-name', but forgot to update the help in qemu-storage-daemon.
Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
storage-daemon/qemu-storage-daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c
index 7cbdbf0b23..42839c981f 100644
--- a/storage-daemon/qemu-storage-daemon.c
+++ b/storage-daemon/qemu-storage-daemon.c
@@ -92,7 +92,7 @@ static void help(void)
" --chardev <options> configure a character device backend\n"
" (see the qemu(1) man page for possible options)\n"
"\n"
-" --export [type=]nbd,device=<node-name>,id=<id>,[,name=<export-name>]\n"
+" --export [type=]nbd,id=<id>,node-name=<node-name>,[,name=<export-name>]\n"
" [,writable=on|off][,bitmap=<name>]\n"
" export the specified block node over NBD\n"
" (requires --nbd-server)\n"
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qemu-storage-daemon: Fix help line for --export
2020-09-30 13:39 [PATCH] qemu-storage-daemon: Fix help line for --export Kevin Wolf
@ 2020-09-30 13:48 ` Eric Blake
2020-09-30 14:59 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2020-09-30 13:48 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 1452 bytes --]
On 9/30/20 8:39 AM, Kevin Wolf wrote:
> Commit 5f479a8d renamed the 'device' option of --export into
> 'node-name', but forgot to update the help in qemu-storage-daemon.
>
> Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> storage-daemon/qemu-storage-daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c
> index 7cbdbf0b23..42839c981f 100644
> --- a/storage-daemon/qemu-storage-daemon.c
> +++ b/storage-daemon/qemu-storage-daemon.c
> @@ -92,7 +92,7 @@ static void help(void)
> " --chardev <options> configure a character device backend\n"
> " (see the qemu(1) man page for possible options)\n"
> "\n"
> -" --export [type=]nbd,device=<node-name>,id=<id>,[,name=<export-name>]\n"
> +" --export [type=]nbd,id=<id>,node-name=<node-name>,[,name=<export-name>]\n"
While touching this, get rid of the doubled comma before the optional
name key (s/,\[,/\[,/)
With that,
Reviewed-by: Eric Blake <eblake@redhat.com>
> " [,writable=on|off][,bitmap=<name>]\n"
> " export the specified block node over NBD\n"
> " (requires --nbd-server)\n"
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qemu-storage-daemon: Fix help line for --export
2020-09-30 13:48 ` Eric Blake
@ 2020-09-30 14:59 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2020-09-30 14:59 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
Am 30.09.2020 um 15:48 hat Eric Blake geschrieben:
> On 9/30/20 8:39 AM, Kevin Wolf wrote:
> > Commit 5f479a8d renamed the 'device' option of --export into
> > 'node-name', but forgot to update the help in qemu-storage-daemon.
> >
> > Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > storage-daemon/qemu-storage-daemon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c
> > index 7cbdbf0b23..42839c981f 100644
> > --- a/storage-daemon/qemu-storage-daemon.c
> > +++ b/storage-daemon/qemu-storage-daemon.c
> > @@ -92,7 +92,7 @@ static void help(void)
> > " --chardev <options> configure a character device backend\n"
> > " (see the qemu(1) man page for possible options)\n"
> > "\n"
> > -" --export [type=]nbd,device=<node-name>,id=<id>,[,name=<export-name>]\n"
> > +" --export [type=]nbd,id=<id>,node-name=<node-name>,[,name=<export-name>]\n"
>
> While touching this, get rid of the doubled comma before the optional
> name key (s/,\[,/\[,/)
Somehow I didn't even notice even though I reordered the options before
it. I'm removing the extra comma now.
> With that,
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks, applied.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-30 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-30 13:39 [PATCH] qemu-storage-daemon: Fix help line for --export Kevin Wolf
2020-09-30 13:48 ` Eric Blake
2020-09-30 14:59 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).