From: Eric Blake <eblake@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
ashijeetacharya@gmail.com, jcody@redhat.com, mreitz@redhat.com,
armbru@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 2/2] block/nfs: fix naming of runtime opts
Date: Tue, 31 Jan 2017 10:07:04 -0600 [thread overview]
Message-ID: <e77b239c-6c6e-821e-07c2-2009d3cc7163@redhat.com> (raw)
In-Reply-To: <1485878172-15463-3-git-send-email-pl@kamp.de>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On 01/31/2017 09:56 AM, Peter Lieven wrote:
> commit 94d6a7a accidently left the naming of runtime opts and QAPI
> scheme inconsistent. As one consequence passing of parameters in the
> URI is broken. Sync the naming of the runtime opts to the QAPI
> scheme.
>
> Please note that this is technically backwards incompatible with the 2.8
> release, but the 2.8 release is the only version that had the wrong naming.
> Furthermore release 2.8 suffered from a NULL pointer deference during
s/deference/dereference/
> URI parsing.
>
> Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Peter Lieven <pl@kamp.de>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Maintainer can touch that up, my review stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-31 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 15:56 [Qemu-devel] [PATCH V2 0/2] fix segfault and naming of runtime opts Peter Lieven
2017-01-31 15:56 ` [Qemu-devel] [PATCH V2 1/2] block/nfs: fix NULL pointer dereference in URI parsing Peter Lieven
2017-01-31 15:56 ` [Qemu-devel] [PATCH V2 2/2] block/nfs: fix naming of runtime opts Peter Lieven
2017-01-31 16:07 ` Eric Blake [this message]
2017-02-01 1:06 ` Max Reitz
2017-02-01 9:22 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e77b239c-6c6e-821e-07c2-2009d3cc7163@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).