From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: isaku.yamahata@gmail.com, qemu-devel@nongnu.org,
imammedo@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com
Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH 4/4] i386: acpi: Don't build HPET ACPI entry if HPET is disabled
Date: Thu, 4 Feb 2021 09:56:10 +0100 [thread overview]
Message-ID: <e7888b9b-348b-871c-7d4b-378182baa48d@redhat.com> (raw)
In-Reply-To: <d62e491a87a698dc8fd703815867013e04f49c2c.1612424814.git.isaku.yamahata@intel.com>
On 2/4/21 9:04 AM, isaku.yamahata@gmail.com wrote:
> From: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Omit HPET AML if the HPET is disabled, QEMU is not emulating it and the
> guest may get confused by seeing HPET in the ACPI tables without a
> "physical" device present.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> hw/i386/acpi-build.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-02-04 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:04 [PATCH 0/4] ACPI related fixes isaku.yamahata
2021-02-04 8:04 ` [PATCH 1/4] acpi/core: always set SCI_EN when SMM isn't supported isaku.yamahata
2021-02-04 8:04 ` [PATCH 2/4] acpi: set fadt.smi_cmd to zero when SMM is not supported isaku.yamahata
2021-02-04 8:04 ` [PATCH 3/4] hw/i386: declare ACPI mother board resource for MMCONFIG region isaku.yamahata
2021-02-04 8:04 ` [PATCH 4/4] i386: acpi: Don't build HPET ACPI entry if HPET is disabled isaku.yamahata
2021-02-04 8:56 ` Philippe Mathieu-Daudé [this message]
2021-02-04 8:15 ` [PATCH 0/4] ACPI related fixes no-reply
2021-02-05 13:48 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7888b9b-348b-871c-7d4b-378182baa48d@redhat.com \
--to=philmd@redhat.com \
--cc=imammedo@redhat.com \
--cc=isaku.yamahata@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).