Re: [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On 10/19/2017 09:28 AM, Daniel P. Berrange wrote:
> Hardware scancodes are all documented in hex, so use that in trace
> events to make it easier to understand.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  hw/input/trace-events | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/hw/input/trace-events b/hw/input/trace-events
> index 6fcb3c063f..d04132d342 100644
> --- a/hw/input/trace-events
> +++ b/hw/input/trace-events
> @@ -1,7 +1,7 @@
>  # See docs/devel/tracing.txt for syntax documentation.
>  
>  # hw/input/ps2.c
> -ps2_put_keycode(void *opaque, int keycode) "%p keycode %d"
> +ps2_put_keycode(void *opaque, int keycode) "%p keycode 0x%02x"
>  ps2_read_data(void *opaque) "%p"
>  ps2_set_ledstate(void *s, int ledstate) "%p ledstate %d"
>  ps2_reset_keyboard(void *s) "%p"
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 615 bytes --]