From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Luis Machado <luis.machado@linaro.org>
Subject: Re: [PATCH 4/5] target/arm: Don't put FPEXC and FPSID in org.gnu.gdb.arm.vfp XML
Date: Tue, 21 Sep 2021 20:30:37 -0700 [thread overview]
Message-ID: <e7cbadb7-b475-2fc3-7813-e42519282b59@linaro.org> (raw)
In-Reply-To: <20210921162901.17508-5-peter.maydell@linaro.org>
On 9/21/21 9:29 AM, Peter Maydell wrote:
> Currently we send VFP XML which includes D0..D15 or D0..D31, plus
> FPSID, FPSCR and FPEXC. The upstream GDB tolerates this, but its
> definition of this XML feature does not include FPSID or FPEXC. In
> particular, for M-profile cores there are no FPSID or FPEXC
> registers, so advertising those is wrong.
>
> Move FPSID and FPEXC into their own bit of XML which we only send for
> A and R profile cores. This brings our definition of the XML
> org.gnu.gdb.arm.vfp feature into line with GDB's own (at least for
> non-Neon cores...) and means we don't claim to have FPSID and FPEXC
> on M-profile.
>
> (It seems unlikely to me that any gdbstub users really care about
> being able to look at FPEXC and FPSID; but we've supplied them to gdb
> for a decade and it's not hard to keep doing so.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-09-22 3:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 16:28 [PATCH 0/5] target/arm: Support MVE in gdbstub Peter Maydell
2021-09-21 16:28 ` [PATCH 1/5] configs: Don't include 32-bit-only GDB XML in aarch64 linux configs Peter Maydell
2021-09-22 3:04 ` Richard Henderson
2021-09-21 16:28 ` [PATCH 2/5] target/arm: Fix coding style issues in gdbstub code in helper.c Peter Maydell
2021-09-21 18:10 ` Philippe Mathieu-Daudé
2021-09-22 3:16 ` Richard Henderson
2021-09-21 16:28 ` [PATCH 3/5] target/arm: Move gdbstub related code out of helper.c Peter Maydell
2021-09-21 18:10 ` Philippe Mathieu-Daudé
2021-09-22 3:22 ` Richard Henderson
2021-09-21 16:29 ` [PATCH 4/5] target/arm: Don't put FPEXC and FPSID in org.gnu.gdb.arm.vfp XML Peter Maydell
2021-09-22 3:30 ` Richard Henderson [this message]
2021-09-21 16:29 ` [PATCH 5/5] [RFC] target/arm: Advertise MVE to gdb when present Peter Maydell
2021-09-22 3:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7cbadb7-b475-2fc3-7813-e42519282b59@linaro.org \
--to=richard.henderson@linaro.org \
--cc=luis.machado@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).