Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

[meta-comment]

On 10/20/2016 04:52 AM, Anand J wrote:
> Added script to check duplicate #include entries. This check will scan
> and print the files in which duplicate #include entries are present.

This appears to be a v2 patch.  But it is missing a 0/2 cover letter,
and mention of v2 in the subject line.  'git format-patch --cover-letter
-v2' will do what you want (as well as git send-email, which understands
all options accepted by format-patch); it's also possible to automate
git to send a cover letter any time you send more than one patch by
using 'git config format.coverLetter auto'.

More patch submission tips at http://wiki.qemu.org/Contribute/SubmitAPatch

> 
> Script might output false positive entries as well. Such entries should
> not be removed. So if it finds any duplicate entries script will
> terminate with an exit status 1. Then each and every file should be
> checked manually and corrected if necessary.
> 
> In order to enable the check use --check-duphead option with
> script/clean-includes.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Anand J <anand.indukala@gmail.com>
> ---
>  scripts/clean-includes | 50 +++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 37 insertions(+), 13 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]